[Test] migrate-junit5-client-module and parameterized beforeEach#4518
Open
sherlock-lin wants to merge 1 commit intoapache:masterfrom
Open
[Test] migrate-junit5-client-module and parameterized beforeEach#4518sherlock-lin wants to merge 1 commit intoapache:masterfrom
sherlock-lin wants to merge 1 commit intoapache:masterfrom
Conversation
sherlock-lin
force-pushed
the
sherlock-migrate-junit5-client-moudule-1024
branch
6 times, most recently
from
fb12e3c to
f0e8158
Compare
Contributor
Author
|
@shoothzj please help review |
hezhangjian
reviewed
Oct 25, 2024
Member
hezhangjian
left a comment
hezhangjian
left a comment
There was a problem hiding this comment.
Overall looks good, can we use four indents in new code of bookkeeper-server/src/test/java/org/apache/bookkeeper/client/HandleFailuresTest.java?
Contributor
Author
sure😊 |
sherlock-lin
force-pushed
the
sherlock-migrate-junit5-client-moudule-1024
branch
2 times, most recently
from
7968110 to
66add87
Compare
hezhangjian
approved these changes
Oct 25, 2024
Member
|
reopen's reason: rerun failure checks |
Contributor
|
CI is failing: |
Member
|
reopen's reason: rerun failure checks |
Member
@sherlock-lin take some time to deal with this issue. |
sherlock-lin
force-pushed
the
sherlock-migrate-junit5-client-moudule-1024
branch
from
66add87 to
f517b42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue: #4322
1. why parameterized beforeEach
Because the current version of Junit 5 does not support class-level parameterized， related links，We can achieve the same effect by beforeEach。
2. Short-term solutions(this pr)
Refer to this post custom ParameterResolver and beforeEach implementations class-level parameterized
3. Long-term solutions
Keep up with the Junit5 community, and when Junit5 supports class-level parameterized, go with the official Junit5 way!
Test results