Delete cookie as part of decommission API

[SongOf]

Implement the logic in BP-68: Delete cookie as part of decommission API.

[StevenLuMT]

I think it's the same as this historical PR #4541 . I think it's quite high risk and there's no need to add this function.
@SongOf

[StevenLuMT]

I suggest temporarily closing this PR and reopening it later if necessary.

[StevenLuMT]

The command line decommission will delete cookies by default, but the http api does not have the alignment function

[StevenLuMT]

good jobs:
The command line decommission will delete cookies by default, but the http api does not have the alignment function

[StevenLuMT]

@hezhangjian @zymap help review this pr, thanks

[zymap]

You can use Awaitility to verify the condition periodically instead of sleeping.

        Awaitility.await().untilAsserted(() -> {
            assertTrue("Bookie should be running and converted to readonly mode",
                    bookie.isRunning() && bookie.isReadOnly());
        });

[SongOf]

You can use Awaitility to verify the condition periodically instead of sleeping.

        Awaitility.await().untilAsserted(() -> {
            assertTrue("Bookie should be running and converted to readonly mode",
                    bookie.isRunning() && bookie.isReadOnly());
        });

fixed, Thanks for your suggestion.

[zymap]

Same above.

[SongOf]

Same above.

fixed, Thanks for your suggestion.

[AbdulElahOthmanGwaith]

// wait decommission finish
Awaitility.await()
.untilAsserted(() -> {
Versioned clusterInfo =
admin.getClusterInfo();
assertFalse(
clusterInfo.getValue()
.getBookies()
.contains(bookieId)
);
});