feat: support equalsAndHashcode for BookieServerInfo
#4686
Merged
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mattisonchao <[email protected]>
2 tasks
Member
Author
|
rerun failure checks |
Member
Author
|
rerun failure checks |
2 similar comments
Member
Author
|
rerun failure checks |
Member
Author
|
rerun failure checks |
zymap
approved these changes
Nov 24, 2025
hangc0276
approved these changes
Nov 25, 2025
lhotari
pushed a commit
that referenced
this pull request
Nov 28, 2025
* feat: support equalsAndHashcode for BookieServerInfo Signed-off-by: mattisonchao <[email protected]> * change order * fix checkstyle * fix checkstyle --------- Signed-off-by: mattisonchao <[email protected]> (cherry picked from commit 14c2ffe)
priyanshu-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Dec 2, 2025
* feat: support equalsAndHashcode for BookieServerInfo Signed-off-by: mattisonchao <[email protected]> * change order * fix checkstyle * fix checkstyle --------- Signed-off-by: mattisonchao <[email protected]> (cherry picked from commit 14c2ffe) (cherry picked from commit 6338d45)
srinath-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Dec 4, 2025
* feat: support equalsAndHashcode for BookieServerInfo Signed-off-by: mattisonchao <[email protected]> * change order * fix checkstyle * fix checkstyle --------- Signed-off-by: mattisonchao <[email protected]> (cherry picked from commit 14c2ffe) (cherry picked from commit 6338d45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
BookieServerInfoclass is exposed to the metadata store plugin. We need to supportequalsAndHashcodeto help other plugins encode or decode it with comparison.FYI: apache/pulsar#25001
Changes
equalsAndHashcodemethod forBookieServerInfoand underlyingEndpoint