From 53ebbbb8623d7cdec912d34d776eda6dfdf41ac8 Mon Sep 17 00:00:00 2001 From: xiangying Date: Fri, 15 Aug 2025 15:38:35 +0800 Subject: [PATCH] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure --- .../java/org/apache/bookkeeper/client/LedgerHandle.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java index 7d1f67a2e4b..0c4d80ad103 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java @@ -2148,10 +2148,8 @@ void maybeHandleDelayedWriteBookieFailure() { return; } - // Original intent of this change is to do a best-effort ensemble change. - // But this is not possible until the local metadata is completely immutable. - // Until the feature "Make LedgerMetadata Immutable #610" Is complete we will use - // handleBookieFailure() to handle delayed writes as regular bookie failures. + // Treat delayed-write failures as regular bookie failures and trigger an ensemble change. + // LedgerMetadata is immutable now (#281), so this is handled via MetadataUpdateLoop. handleBookieFailure(toReplace); }