Skip to content

Commit 349c102

Browse files
committed
fix checkstyle
1 parent c2be9f0 commit 349c102

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

core/src/test/java/org/apache/calcite/test/JdbcTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9070,12 +9070,14 @@ void checkCalciteSchemaGetSubSchemaMap(boolean cache) {
90709070

90719071
/** Test case for
90729072
* <a href="https://issues.apache.org/jira/browse/CALCITE-5094">[CALCITE-5094]
9073-
* Calcite JDBC Adapter and Avatica should support MySQL UNSIGNED types of TINYINT, SMALLINT, INT, BIGINT</a>. */
9073+
* Calcite JDBC Adapter and Avatica should support
9074+
* MySQL UNSIGNED types of TINYINT, SMALLINT, INT, BIGINT</a>. */
90749075
@Test void testMySQLUnsignedType() {
90759076
CalciteAssert.that()
90769077
.with(CalciteAssert.SchemaSpec.UNSIGNED_TYPE)
90779078
.with(Lex.MYSQL)
9078-
.query("SELECT * FROM test_unsigned WHERE tiny_id = ? AND small_id = ? AND int_id = ? AND big_id = ?")
9079+
.query("SELECT * FROM test_unsigned WHERE tiny_id = ? "
9080+
+ "AND small_id = ? AND int_id = ? AND big_id = ?")
90799081
.consumesPreparedStatement(p -> {
90809082
p.setInt(1, 255);
90819083
p.setInt(2, 65535);

linq4j/src/main/java/org/apache/calcite/linq4j/tree/UnsignedType.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
*/
1717
package org.apache.calcite.linq4j.tree;
1818

19-
import com.google.common.base.Preconditions;
20-
2119
import org.checkerframework.checker.nullness.qual.Nullable;
2220
import org.joou.UByte;
2321
import org.joou.UInteger;
@@ -30,6 +28,8 @@
3028
import java.math.BigInteger;
3129
import java.math.RoundingMode;
3230

31+
import static com.google.common.base.Preconditions.checkArgument;
32+
3333
/** Support for compiling unsigned types.
3434
* This class has a role similar to {@link Primitive} */
3535
public enum UnsignedType {
@@ -112,7 +112,7 @@ public static UByte toUByte(double n) {
112112
}
113113

114114
public static UByte toUByte(Object n) {
115-
Preconditions.checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
115+
checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
116116
return toUByteNonNull((Number) n, RoundingMode.DOWN);
117117
}
118118

@@ -171,7 +171,7 @@ public static UShort toUShort(double n) {
171171
}
172172

173173
public static UShort toUShort(Object n) {
174-
Preconditions.checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
174+
checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
175175
return toUShortNonNull((Number) n, RoundingMode.DOWN);
176176
}
177177

@@ -234,7 +234,7 @@ public static UInteger toUInteger(double n) {
234234
}
235235

236236
public static UInteger toUInteger(Object n) {
237-
Preconditions.checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
237+
checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
238238
return toUIntegerNonNull((Number) n, RoundingMode.DOWN);
239239
}
240240

@@ -293,7 +293,7 @@ public static ULong toULong(double n) {
293293
}
294294

295295
public static ULong toULong(Object n) {
296-
Preconditions.checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
296+
checkArgument(n instanceof Number, "Unexpected Object value " + n.getClass().getSimpleName());
297297
return toULongNonNull((Number) n, RoundingMode.DOWN);
298298
}
299299

testkit/src/main/java/org/apache/calcite/test/CalciteAssert.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2366,12 +2366,12 @@ static List<String> unwrap(String java) {
23662366
/** Schema instance for {@link SchemaSpec#UNSIGNED_TYPE}. */
23672367
private static final Schema UNSIGNED_TYPE_SCHEMA = new AbstractSchema() {
23682368

2369-
@Override
2370-
protected Map<String, Table> getTableMap() {
2369+
@Override protected Map<String, Table> getTableMap() {
23712370
return ImmutableMap.of("test_unsigned", new UnsingedScannableTable());
23722371
}
23732372
};
23742373

2374+
/** Scannable table for unsigned types test. */
23752375
private static class UnsingedScannableTable extends AbstractTable implements ScannableTable {
23762376

23772377
/**

0 commit comments

Comments
 (0)