[CALCITE-7197] UnsupportedOperationException when using dynamic parameters inside ROW expression

Author: strongduanmu

core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java

@@ -2126,6 +2126,10 @@ protected void inferUnknownTypes(
       setValidatedNodeType(node, newInferredType);
     } else if (node instanceof SqlNodeList) {
       SqlNodeList nodeList = (SqlNodeList) node;
+      if (isRowSqlNodeList(inferredType, nodeList)) {
+        inferRowSqlNodeList(inferredType, scope, nodeList);
+        return;
+      }
       if (inferredType.isStruct()) {
         if (inferredType.getFieldCount() != nodeList.size()) {
           // this can happen when we're validating an INSERT
@@ -2204,6 +2208,25 @@ protected void inferUnknownTypes(
     }
   }
 
+  private boolean isRowSqlNodeList(final RelDataType inferredType, final SqlNodeList nodeList) {
+    return inferredType.isStruct() && !nodeList.isEmpty()
+        && SqlKind.ROW == nodeList.get(0).getKind();
+  }
+
+  private void inferRowSqlNodeList(final RelDataType inferredType,
+      final SqlValidatorScope scope, final SqlNodeList nodeList) {
+    for (SqlNode child : nodeList) {
+      if (!(child instanceof SqlBasicCall)) {
+        continue;
+      }
+      List<SqlNode> operands = ((SqlBasicCall) child).getOperandList();
+      for (int index = 0; index < operands.size(); index++) {
+        RelDataType type = inferredType.getFieldList().get(index).getType();
+        inferUnknownTypes(type, scope, operands.get(index));
+      }
+    }
+  }
+
   /**
    * Adds an expression to a select list, ensuring that its alias does not
    * clash with any existing expressions on the list.

core/src/test/java/org/apache/calcite/test/JdbcTest.java

@@ -9012,6 +9012,28 @@ void checkCalciteSchemaGetSubSchemaMap(boolean cache) {
         });
   }
 
+  @Test void testSelectWithPlaceholdersInRowExpression() {
+    CalciteAssert.that()
+        .with(Lex.MYSQL)
+        .with(CalciteAssert.Config.SCOTT)
+        .query("select empno, ename from emp\n"
+            + "where row(empno, ename) in ((?, ?))")
+        .consumesPreparedStatement(p -> {
+          p.setInt(1, 7782);
+          p.setString(2, "CLARK");
+        })
+        .returns(resultSet -> {
+          try {
+            assertTrue(resultSet.next());
+            assertThat(resultSet.getInt(1), is(7782));
+            assertThat(resultSet.getString(2), is("CLARK"));
+            assertFalse(resultSet.next());
+          } catch (SQLException e) {
+            throw new RuntimeException(e);
+          }
+        });
+  }
+
   /** Test case for
    * <a href="https://issues.apache.org/jira/browse/CALCITE-5414">[CALCITE-5414]</a>
    * Convert between standard Gregorian and proleptic Gregorian calendars for

core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java

@@ -12405,6 +12405,23 @@ private void checkCustomColumnResolving(String table) {
         .fails(maxError);
   }
 
+  @Test void testSelectWithRowExpressionPredicate() {
+    // test single row expression values
+    sql("select empno, ename from emp where row(empno, ename) in ((?, ?))")
+        .ok()
+        .assertBindType(is("RecordType(INTEGER ?0, VARCHAR(20) ?1)"));
+
+    // test multiple row expression values
+    sql("select empno, ename from emp where row(empno, ename) in ((?, ?), (7782, ?), (?, 'CLARK'))")
+        .ok()
+        .assertBindType(is("RecordType(INTEGER ?0, VARCHAR(20) ?1, VARCHAR(20) ?2, INTEGER ?3)"));
+
+    // test single row expression values with expression
+    sql("select empno, ename from emp where row(empno, ename) in ((? + 1, ?))")
+        .ok()
+        .assertBindType(is("RecordType(INTEGER ?0, VARCHAR(20) ?1)"));
+  }
+
   @Test void testRolledUpColumnInWhere() {
     final String error = "Rolled up column 'SLACKINGMIN' is not allowed in GREATER_THAN";
 

core/src/test/resources/sql/conditions.iq

@@ -547,4 +547,20 @@ where 5 < cast(deptno as integer) OR 5 >= cast(deptno as integer) OR deptno IS N
 EnumerableTableScan(table=[[scott, EMP]])
 !plan
 
+!use scott
+
+select *
+from "scott".emp
+where row(empno, ename) in ((7782, 'CLARK'), (7902, 'FORD'), (7839, 'KING'));
++-------+-------+-----------+------+------------+---------+------+--------+
+| EMPNO | ENAME | JOB       | MGR  | HIREDATE   | SAL     | COMM | DEPTNO |
++-------+-------+-----------+------+------------+---------+------+--------+
+|  7782 | CLARK | MANAGER   | 7839 | 1981-06-09 | 2450.00 |      |     10 |
+|  7839 | KING  | PRESIDENT |      | 1981-11-17 | 5000.00 |      |     10 |
+|  7902 | FORD  | ANALYST   | 7566 | 1981-12-03 | 3000.00 |      |     20 |
++-------+-------+-----------+------+------------+---------+------+--------+
+(3 rows)
+
+!ok
+
 # End conditions.iq