Skip to content

Commit a8cd4bd

Browse files
author
Terran
committed
Del REGEXP SqlKind
1 parent e2c80f3 commit a8cd4bd

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

core/src/main/java/org/apache/calcite/sql/SqlKind.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1357,10 +1357,7 @@ public enum SqlKind {
13571357
* commands for them. Use OTHER_DDL in the short term, but we are happy to add
13581358
* new enum values for your object types. Just ask!
13591359
*/
1360-
OTHER_DDL,
1361-
1362-
/** The {@code REGEXP} function. */
1363-
REGEXP;
1360+
OTHER_DDL;
13641361

13651362
//~ Static fields/initializers ---------------------------------------------
13661363

core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public HiveSqlDialect(Context context) {
129129
case TRIM:
130130
RelToSqlConverterUtil.unparseHiveTrim(writer, call, leftPrec, rightPrec);
131131
break;
132-
case REGEXP:
132+
case RLIKE:
133133
RelToSqlConverterUtil.unparseRegexp(writer, call, leftPrec, rightPrec);
134134
break;
135135
default:

core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -707,7 +707,7 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding operatorBinding,
707707
/** The "REGEXP(value, regexp)" function, equivalent to {@link #RLIKE}. */
708708
@LibraryOperator(libraries = {SPARK, HIVE})
709709
public static final SqlFunction REGEXP =
710-
SqlBasicFunction.create(SqlKind.REGEXP, ReturnTypes.BOOLEAN_NULLABLE,
710+
SqlBasicFunction.create("REGEXP", SqlKind.RLIKE, ReturnTypes.BOOLEAN_NULLABLE,
711711
OperandTypes.STRING_STRING);
712712

713713
/** The "REGEXP_LIKE(value, regexp)" function, equivalent to {@link #RLIKE}. */

core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -454,12 +454,13 @@ public static void unparseRegexp(SqlWriter writer, SqlCall call, int leftPrec, i
454454
if (call.operandCount() != 2) {
455455
throw new IllegalArgumentException("REGEXP operator requires exactly 2 operands");
456456
}
457-
458-
final SqlWriter.Frame frame = writer.startList(SqlWriter.FrameTypeEnum.SIMPLE, "(", ")");
459-
call.operand(0).unparse(writer, leftPrec, rightPrec);
460-
writer.sep("REGEXP", true);
461-
call.operand(1).unparse(writer, leftPrec, rightPrec);
462-
writer.endList(frame);
457+
if ("REGEXP".equals(call.getOperator().getName())) {
458+
final SqlWriter.Frame frame = writer.startList(SqlWriter.FrameTypeEnum.SIMPLE, "(", ")");
459+
call.operand(0).unparse(writer, leftPrec, rightPrec);
460+
writer.sep("REGEXP", true);
461+
call.operand(1).unparse(writer, leftPrec, rightPrec);
462+
writer.endList(frame);
463+
}
463464
}
464465

465466
}

0 commit comments

Comments
 (0)