[CALCITE-7323] Result of cast Number to Boolean is not correct

Author: xuzifu666

core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java

@@ -428,6 +428,20 @@ private Expression getConvertExpression(
       case CHAR:
       case VARCHAR:
         return Expressions.call(BuiltInMethod.STRING_TO_BOOLEAN.method, operand);
+      // Numberic type handle
+      case TINYINT:
+      case SMALLINT:
+      case INTEGER:
+      case BIGINT:
+      case UTINYINT:
+      case USMALLINT:
+      case UINTEGER:
+      case UBIGINT:
+      case DECIMAL:
+      case FLOAT:
+      case REAL:
+      case DOUBLE:
+        return Expressions.call(BuiltInMethod.NUMBER_TO_BOOLEAN.method, operand);
 
       default:
         return defaultExpression.get();

core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

@@ -4735,6 +4735,18 @@ public static boolean toBoolean(String s) {
   }
 
   public static boolean toBoolean(Number number) {
+    if (number instanceof BigDecimal) {
+      BigDecimal decimal = (BigDecimal) number;
+      return decimal.compareTo(BigDecimal.ZERO) != 0;
+    }
+    if (number instanceof Double) {
+      Double d = (Double) number;
+      return !d.equals(Double.valueOf(0));
+    }
+    if (number instanceof Float) {
+      Float f = (Float) number;
+      return !f.equals(Float.valueOf(0));
+    }
     return !number.equals(0);
   }
 

core/src/main/java/org/apache/calcite/util/BuiltInMethod.java

@@ -682,6 +682,7 @@ public enum BuiltInMethod {
       "getModifiableCollection"),
   SCANNABLE_TABLE_SCAN(ScannableTable.class, "scan", DataContext.class),
   STRING_TO_BOOLEAN(SqlFunctions.class, "toBoolean", String.class),
+  NUMBER_TO_BOOLEAN(SqlFunctions.class, "toBoolean", Number.class),
   INTERNAL_TO_DATE(SqlFunctions.class, "internalToDate", int.class),
   INTERNAL_TO_TIME(SqlFunctions.class, "internalToTime", int.class),
   INTERNAL_TO_TIMESTAMP(SqlFunctions.class, "internalToTimestamp", long.class),

core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java

@@ -771,6 +771,10 @@ private static String toSql(RelNode root, SqlDialect dialect,
     query = "select FALSE = 0.0e0";
     expected = "SELECT *\nFROM (VALUES (TRUE)) AS \"t\" (\"EXPR$0\")";
     sql(query).ok(expected);
+
+    query = "select cast(\"product_id\" as BOOLEAN) from \"product\"";
+    expected = "SELECT \"product_id\" <> 0\nFROM \"foodmart\".\"product\"";
+    sql(query).ok(expected);
   }
 
   @Test void testSelectQueryWithWhereClauseOfBasicOperators() {

core/src/test/java/org/apache/calcite/rex/RexProgramTest.java

@@ -3152,7 +3152,9 @@ private SqlOperator getNoDeterministicOperator() {
     checkSimplify(cast(literal(1), varcharType), "'1':VARCHAR(10)");
     checkSimplifyUnchanged(cast(literalAbc, booleanType));
     checkSimplify(cast(literal(1), booleanType),
-        "false"); // different from Hive
+        "true");
+    checkSimplify(cast(literal(0), booleanType),
+        "false");
     checkSimplifyUnchanged(cast(literalAbc, dateType));
     checkSimplify(cast(literal(1), dateType),
         "1970-01-02"); // different from Hive

core/src/test/resources/sql/cast.iq

@@ -1978,4 +1978,28 @@ SELECT ARRAY[cast(null as integer), cast(null as integer), cast(null as integer)
 EXPR$0 INTEGER ARRAY NOT NULL
 !type
 
+# [CALCITE-7323] Result of cast Number to Boolean is not correct
+select cast(mod(deptno, 3) as BOOLEAN), mod(deptno, 3) from emp;
++--------+--------+
+| EXPR$0 | EXPR$1 |
++--------+--------+
+| false  |      0 |
+| false  |      0 |
+| false  |      0 |
+| false  |      0 |
+| false  |      0 |
+| false  |      0 |
+| true   |      1 |
+| true   |      1 |
+| true   |      1 |
+| true   |      2 |
+| true   |      2 |
+| true   |      2 |
+| true   |      2 |
+| true   |      2 |
++--------+--------+
+(14 rows)
+
+!ok
+
 # End cast.iq

testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

@@ -825,6 +825,36 @@ void testCastToExactNumeric(CastType castType, SqlOperatorFixture f) {
     f.checkNull("CAST(CAST(NULL AS VARCHAR) AS VARBINARY)");
   }
 
+  /**
+   * Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7323">
+   * Result of cast Number to Boolean is not correct</a>. */
+  @Test public void testNumbericBooleanCast() {
+    SqlOperatorFixture f = fixture();
+    f.setFor(SqlStdOperatorTable.MAX, VM_EXPAND);
+    String[] values = {"0", "CAST(null AS INTEGER)", "2", "2"};
+    f.checkAgg("cast(max(x) as BOOLEAN)", values, isSingle(true));
+    String[] values1 = {"0", "CAST(null AS INTEGER)", "0", "-2"};
+    f.checkAgg("cast(max(x) as BOOLEAN)", values1, isSingle(false));
+    f.checkScalar("CAST(1 AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(2 AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(abs(2) AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(abs(0) AS BOOLEAN)", "false", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(-1 AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(1.2 AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(CAST(100.5e0 AS DECIMAL(4, 1)) AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(0 AS BOOLEAN)", "false", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(0.0 AS BOOLEAN)", "false", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(0.0e0 AS BOOLEAN)", "false", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(0.01e0 AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(0e0 AS BOOLEAN)", "false", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(-0e0 AS BOOLEAN)", "false", "BOOLEAN NOT NULL");
+    f.checkNull("CAST(NULL AS BOOLEAN)");
+    f.checkScalar("CAST(CAST(1.2 AS FLOAT) AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(CAST(1.2 AS Double) AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(cast(1 as INTEGER UNSIGNED) AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+    f.checkScalar("CAST(cast(1 as TINYINT UNSIGNED) AS BOOLEAN)", "true", "BOOLEAN NOT NULL");
+  }
+
   @ParameterizedTest
   @MethodSource("safeParameters")
   void testCastStringToDecimal(CastType castType, SqlOperatorFixture f) {