use constant for default container annotation

Author: pkalsi97

pkg/trait/container.go

@@ -45,9 +45,10 @@ const (
 	containerTraitID    = "container"
 	containerTraitOrder = 1600
 
-	defaultContainerName = "integration"
-	defaultContainerPort = 8080
-	defaultServicePort   = 80
+	defaultContainerName       = "integration"
+	defaultContainerAnnotation = "kubectl.kubernetes.io/default-container"
+	defaultContainerPort       = 8080
+	defaultServicePort         = 80
 
 	defaultContainerRunAsNonRoot             = false
 	defaultContainerSeccompProfileType       = corev1.SeccompProfileTypeRuntimeDefault

pkg/trait/cron.go

@@ -241,7 +241,7 @@ func (t *cronTrait) getCronJobFor(e *Environment) *batchv1.CronJob {
 	}
 
 	// Set the default container annotation for kubectl commands
-	annotations["kubectl.kubernetes.io/default-container"] = defaultContainerName
+	annotations[defaultContainerAnnotation] = defaultContainerName
 
 	activeDeadline := defaultCronActiveDeadlineSeconds
 	if t.ActiveDeadlineSeconds != nil {

pkg/trait/deployment.go

@@ -119,7 +119,7 @@ func (t *deploymentTrait) getDeploymentFor(e *Environment) *appsv1.Deployment {
 	}
 
 	// Set the default container annotation for kubectl commands
-	annotations["kubectl.kubernetes.io/default-container"] = defaultContainerName
+	annotations[defaultContainerAnnotation] = defaultContainerName
 
 	deadline := defaultProgressDeadline
 	if t.ProgressDeadlineSeconds != nil {

pkg/trait/knative_service.go

@@ -195,7 +195,7 @@ func (t *knativeServiceTrait) getServiceFor(e *Environment) (*serving.Service, e
 	}
 
 	// Set the default container annotation for kubectl
-	revisionAnnotations["kubectl.kubernetes.io/default-container"] = defaultContainerName
+	revisionAnnotations[defaultContainerAnnotation] = defaultContainerName
 
 	// Set Knative auto-scaling
 	if t.Class != "" {