Hashicorp Vault tests fail to start due to LinkageError

[jamesnetherton]

Bug description

Not sure what's going on here. I see the following if I run the hashicorp-vault tests locally. But they seem to be passing when run on GitHub CI.

Caused by: java.lang.LinkageError: loader constraint violation: loader 'app' wants to load interface org.apache.commons.logging.Log. A different interface with the same name was previously loaded by io.quarkus.bootstrap.classloading.QuarkusClassLoader @36510e73. (org.apache.commons.logging.Log is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @36510e73, parent loader 'app')
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at org.springframework.http.HttpLogging.forLog(HttpLogging.java:68)
	at org.springframework.http.HttpLogging.forLogName(HttpLogging.java:57)
	at org.springframework.http.converter.AbstractHttpMessageConverter.<init>(AbstractHttpMessageConverter.java:53)
	at org.springframework.http.converter.ByteArrayHttpMessageConverter.<init>(ByteArrayHttpMessageConverter.java:44)
	at org.springframework.vault.client.VaultClients.createRestTemplate(VaultClients.java:111)
	at org.springframework.vault.client.VaultClients.createRestTemplate(VaultClients.java:88)
	at org.springframework.vault.client.RestTemplateBuilder.createTemplate(RestTemplateBuilder.java:227)
	at org.springframework.vault.client.RestTemplateBuilder.build(RestTemplateBuilder.java:204)
	at org.springframework.vault.core.VaultTemplate.doCreateRestTemplate(VaultTemplate.java:224)
	at org.springframework.vault.core.VaultTemplate.<init>(VaultTemplate.java:95)
	at org.apache.camel.component.hashicorp.vault.HashicorpVaultEndpoint.createVaultTemplate(HashicorpVaultEndpoint.java:73)
	at org.apache.camel.component.hashicorp.vault.HashicorpVaultEndpoint.doInit(HashicorpVaultEndpoint.java:60)

[jamesnetherton]

I think this is probably an issue for all tests that have Spring on the classpath. It just depends whether org.springframework.core.log.LogDelegateFactory is called.

It's a bit weird because LogDelegateFactory is loaded by the app ClassLoader, but all of the commons-logging stuff is loaded by the Quarkus test ClassLoader.

[jamesnetherton]

The tests pass when integration-tests/hashicorp-vault/src directory is extracted to a standalone app with the same dependencies. I don't understand why it behaves correctly compared to running tests locally from within the Camel Quarkus project.

[jamesnetherton]

@holly-cummins do you have any ideas about this?

[jamesnetherton]

Seems this is another case where odd things happen when Quarkus reads content from extension target directories.

If I do:

cd extensions-support/spring
mvn clean

Then run the hashicorp-vault tests, they magically start passing.

This explains why the tests pass on the CI build. During the itest phase, we download and extract a pre-built .m2 repo. So there are no existing target directories available for Quarkus to dip into. It has to use whatever is in the Maven cache.

[holly-cummins]

I'm going to invoke @aloubyansky on this one. :)

From your description, it sounds maven-resolver-ish.

[aloubyansky]

W/o debugging, my hypothesis is that when the sources and classes are detected, the dependency is categorized as a reloadable one is put in the runtime classloader instead of the base runtime one otherwise. I'll need to confirm whether that's actually the cause.