CAMEL-23271: Move @SuppressWarnings to statement level

Narrow suppression scope: move @SuppressWarnings("java:S2095") from
method level to the local variable declarations where the resources
are created, so it won't mask future issues in the same methods.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: gnodet

core/camel-core-reifier/src/main/java/org/apache/camel/reifier/AggregateReifier.java

@@ -50,7 +50,6 @@ public Processor createProcessor() throws Exception {
         return createAggregator();
     }
 
-    @SuppressWarnings("java:S2095") // ExecutorService lifecycle is managed by AggregateProcessor via shutdownThreadPool flag
     protected AggregateProcessor createAggregator() throws Exception {
         Processor childProcessor = this.createChildProcessor(true);
 
@@ -77,6 +76,8 @@ protected AggregateProcessor createAggregator() throws Exception {
 
         boolean parallel = parseBoolean(definition.getParallelProcessing(), false);
         boolean shutdownThreadPool = willCreateNewThreadPool(definition, parallel);
+        // ExecutorService lifecycle is managed by AggregateProcessor via shutdownThreadPool flag
+        @SuppressWarnings("java:S2095")
         ExecutorService threadPool = getConfiguredExecutorService("Aggregator", definition, parallel);
         if (threadPool == null && !parallel) {
             // executor service is mandatory for the Aggregator

core/camel-core-reifier/src/main/java/org/apache/camel/reifier/ThreadsReifier.java

@@ -34,7 +34,6 @@ public ThreadsReifier(Route route, ProcessorDefinition<?> definition) {
         super(route, (ThreadsDefinition) definition);
     }
 
-    @SuppressWarnings("java:S2095") // ExecutorService lifecycle is managed by ThreadsProcessor via shutdownThreadPool flag
     @Override
     public Processor createProcessor() throws Exception {
         // the threads name
@@ -44,6 +43,8 @@ public Processor createProcessor() throws Exception {
         }
         // prefer any explicit configured executor service
         boolean shutdownThreadPool = willCreateNewThreadPool(definition, true);
+        // ExecutorService lifecycle is managed by ThreadsProcessor via shutdownThreadPool flag
+        @SuppressWarnings("java:S2095")
         ExecutorService threadPool = getConfiguredExecutorService(name, definition, false);
 
         // resolve what rejected policy to use

dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/main/java/org/apache/camel/dsl/yaml/validator/CamelYamlParser.java

@@ -49,8 +49,9 @@
  */
 public class CamelYamlParser {
 
-    @SuppressWarnings("java:S2095") // Registry is owned by CamelContext; CamelContext is stopped in finally block
     public List<ValidationMessage> parse(File file) throws Exception {
+        // CamelContext is stopped in finally block
+        @SuppressWarnings("java:S2095")
         CamelContext camelContext = null;
         try {
             DefaultRegistry registry = new DefaultRegistry();