CAMEL-23271: Fix SonarCloud blocker reliability issues (resource leaks)

- JcrConsumer: store ScheduledExecutorService in a field and shut it down in doStop()
- ModelWriterGeneratorMojo: wrap DynamicClassLoader in try-with-resources
- Set sonar.java.source=17 to eliminate 23 HttpClient false positives
- Add @SuppressWarnings for ExecutorService/CamelContext lifecycle false positives

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: gnodet

components/camel-jcr/src/main/java/org/apache/camel/component/jcr/JcrConsumer.java

@@ -40,6 +40,7 @@ public class JcrConsumer extends DefaultConsumer {
 
     private Session session;
     private EventListener eventListener;
+    private ScheduledExecutorService sessionListenerCheckerExecutor;
     private ScheduledFuture<?> sessionListenerCheckerScheduledFuture;
 
     public JcrConsumer(JcrEndpoint endpoint, Processor processor) {
@@ -159,18 +160,25 @@ private void unregisterListenerAndLogoutSession() throws RepositoryException {
     private void cancelSessionListenerChecker() {
         if (sessionListenerCheckerScheduledFuture != null) {
             sessionListenerCheckerScheduledFuture.cancel(true);
+            sessionListenerCheckerScheduledFuture = null;
+        }
+        if (sessionListenerCheckerExecutor != null) {
+            getJcrEndpoint().getCamelContext().getExecutorServiceManager()
+                    .shutdownNow(sessionListenerCheckerExecutor);
+            sessionListenerCheckerExecutor = null;
         }
     }
 
     private void scheduleSessionListenerChecker() {
         String name = "JcrConsumerSessionChecker[" + getJcrEndpoint().getEndpointConfiguredDestinationName() + "]";
-        ScheduledExecutorService executor = getJcrEndpoint().getCamelContext().getExecutorServiceManager()
+        sessionListenerCheckerExecutor = getJcrEndpoint().getCamelContext().getExecutorServiceManager()
                 .newSingleThreadScheduledExecutor(this, name);
         JcrConsumerSessionListenerChecker sessionListenerChecker = new JcrConsumerSessionListenerChecker();
         long sessionLiveCheckIntervalOnStart = JcrConsumer.this.getJcrEndpoint().getSessionLiveCheckIntervalOnStart();
         long sessionLiveCheckInterval = JcrConsumer.this.getJcrEndpoint().getSessionLiveCheckInterval();
-        sessionListenerCheckerScheduledFuture = executor.scheduleWithFixedDelay(sessionListenerChecker,
-                sessionLiveCheckIntervalOnStart, sessionLiveCheckInterval, TimeUnit.MILLISECONDS);
+        sessionListenerCheckerScheduledFuture = sessionListenerCheckerExecutor.scheduleWithFixedDelay(
+                sessionListenerChecker, sessionLiveCheckIntervalOnStart, sessionLiveCheckInterval,
+                TimeUnit.MILLISECONDS);
     }
 
     private class JcrConsumerSessionListenerChecker implements Runnable {

components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java

@@ -958,6 +958,7 @@ public RawClient createRawClientFor(SalesforceEndpoint endpoint) throws Salesfor
         return new DefaultRawClient(httpClient, "", session, loginConfig);
     }
 
+    @SuppressWarnings("java:S2095") // ExecutorService lifecycle is managed by SalesforceHttpClient
     static SalesforceHttpClient createHttpClient(
             Object source, final SslContextFactory.Client sslContextFactory, final CamelContext context, int workerPoolSize,
             int workerPoolMaxSize) {

core/camel-core-reifier/src/main/java/org/apache/camel/reifier/AggregateReifier.java

@@ -50,6 +50,7 @@ public Processor createProcessor() throws Exception {
         return createAggregator();
     }
 
+    @SuppressWarnings("java:S2095") // ExecutorService lifecycle is managed by AggregateProcessor via shutdownThreadPool flag
     protected AggregateProcessor createAggregator() throws Exception {
         Processor childProcessor = this.createChildProcessor(true);
 

core/camel-core-reifier/src/main/java/org/apache/camel/reifier/ThreadsReifier.java

@@ -34,6 +34,7 @@ public ThreadsReifier(Route route, ProcessorDefinition<?> definition) {
         super(route, (ThreadsDefinition) definition);
     }
 
+    @SuppressWarnings("java:S2095") // ExecutorService lifecycle is managed by ThreadsProcessor via shutdownThreadPool flag
     @Override
     public Processor createProcessor() throws Exception {
         // the threads name

dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/main/java/org/apache/camel/dsl/yaml/validator/CamelYamlParser.java

@@ -49,6 +49,7 @@
  */
 public class CamelYamlParser {
 
+    @SuppressWarnings("java:S2095") // Registry is owned by CamelContext; CamelContext is stopped in finally block
     public List<ValidationMessage> parse(File file) throws Exception {
         CamelContext camelContext = null;
         try {

pom.xml

@@ -122,6 +122,7 @@
 
         <!-- NOTE: this is required to correctly map each module coverage in Sonarqube. The ${maven.multiModuleProjectDirectory} may require some change
             when upgrading to Maven 4.x, according to any of the new variables that will replace this one. -->
+        <sonar.java.source>17</sonar.java.source>
         <sonar.coverage.jacoco.xmlReportPaths>
             ${maven.multiModuleProjectDirectory}/coverage/target/site/jacoco-aggregate/jacoco.xml
         </sonar.coverage.jacoco.xmlReportPaths>

tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/ModelWriterGeneratorMojo.java

@@ -113,13 +113,17 @@ String getModelPackage() {
     abstract String getWriterPackage();
 
     protected String generateWriter() throws MojoExecutionException {
-        ClassLoader classLoader;
-        try {
-            classLoader = DynamicClassLoader.createDynamicClassLoader(project.getCompileClasspathElements());
+        try (DynamicClassLoader classLoader
+                = DynamicClassLoader.createDynamicClassLoader(project.getCompileClasspathElements())) {
+            return doGenerateWriter(classLoader);
         } catch (DependencyResolutionRequiredException e) {
             throw new MojoExecutionException("DependencyResolutionRequiredException: " + e.getMessage(), e);
+        } catch (IOException e) {
+            throw new MojoExecutionException("IOException: " + e.getMessage(), e);
         }
+    }
 
+    private String doGenerateWriter(ClassLoader classLoader) throws MojoExecutionException {
         List<Path> jsonFiles;
         try (Stream<Path> stream = PackageHelper.findJsonFiles(modelDir.toPath())) {
             jsonFiles = stream.toList();