diff --git a/components/camel-ai/camel-chatscript/src/main/java/org/apache/camel/component/chatscript/ChatScriptProducer.java b/components/camel-ai/camel-chatscript/src/main/java/org/apache/camel/component/chatscript/ChatScriptProducer.java index ecc50ab65bb0e..2c8adf7290f5d 100644 --- a/components/camel-ai/camel-chatscript/src/main/java/org/apache/camel/component/chatscript/ChatScriptProducer.java +++ b/components/camel-ai/camel-chatscript/src/main/java/org/apache/camel/component/chatscript/ChatScriptProducer.java @@ -50,7 +50,7 @@ public void process(Exchange exchange) throws Exception { inputMessage.setBotName(endpoint.getBotName()); String response = this.endpoint.getBot().sendChat(inputMessage); inputMessage.setReply(response); - exchange.getOut().setBody(inputMessage); + exchange.getMessage().setBody(inputMessage); } private ChatScriptMessage buildMessage(Object body) throws Exception { diff --git a/components/camel-beanio/src/main/java/org/apache/camel/dataformat/beanio/BeanIODataFormat.java b/components/camel-beanio/src/main/java/org/apache/camel/dataformat/beanio/BeanIODataFormat.java index abb3aed9195a9..498cf34cf0218 100644 --- a/components/camel-beanio/src/main/java/org/apache/camel/dataformat/beanio/BeanIODataFormat.java +++ b/components/camel-beanio/src/main/java/org/apache/camel/dataformat/beanio/BeanIODataFormat.java @@ -202,7 +202,7 @@ private List readModels(Exchange exchange, InputStream stream) throws Ex Object readObject; while ((readObject = in.read()) != null) { if (readObject instanceof BeanIOHeader beanioheader) { - exchange.getOut().getHeaders().putAll(beanioheader.getHeaders()); + exchange.getMessage().getHeaders().putAll(beanioheader.getHeaders()); } results.add(readObject); } diff --git a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java index 51404e36edcd4..55005717d3312 100644 --- a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java +++ b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java @@ -213,7 +213,7 @@ public Object unmarshal(Exchange exchange, InputStream inputStream) throws Excep if (!factory.skipHeader()) { Map headerObjMap = createModel(headerFactory, line, count.intValue()); - exchange.getOut().setHeader(CAMEL_BINDY_FIXED_LENGTH_HEADER, headerObjMap); + exchange.getMessage().setHeader(CAMEL_BINDY_FIXED_LENGTH_HEADER, headerObjMap); } } @@ -242,7 +242,7 @@ public Object unmarshal(Exchange exchange, InputStream inputStream) throws Excep if (factory.hasFooter()) { if (!factory.skipFooter()) { Map footerObjMap = createModel(footerFactory, thisLine, count.intValue()); - exchange.getOut().setHeader(CAMEL_BINDY_FIXED_LENGTH_FOOTER, footerObjMap); + exchange.getMessage().setHeader(CAMEL_BINDY_FIXED_LENGTH_FOOTER, footerObjMap); } } else { model = createModel(factory, thisLine, count.intValue()); diff --git a/components/camel-crypto-pgp/src/main/java/org/apache/camel/converter/crypto/PGPKeyAccessDataFormat.java b/components/camel-crypto-pgp/src/main/java/org/apache/camel/converter/crypto/PGPKeyAccessDataFormat.java index 36fca4cee3b22..1cabdbb79e3de 100644 --- a/components/camel-crypto-pgp/src/main/java/org/apache/camel/converter/crypto/PGPKeyAccessDataFormat.java +++ b/components/camel-crypto-pgp/src/main/java/org/apache/camel/converter/crypto/PGPKeyAccessDataFormat.java @@ -221,7 +221,7 @@ public void marshal(Exchange exchange, Object graph, OutputStream outputStream) "Cannot PGP encrypt message. No public encryption key found for the User Ids " + userids + " in the public keyring. Either specify other User IDs or add correct public keys to the keyring."); } - exchange.getOut().setHeader(NUMBER_OF_ENCRYPTION_KEYS, Integer.valueOf(keys.size())); + exchange.getMessage().setHeader(NUMBER_OF_ENCRYPTION_KEYS, Integer.valueOf(keys.size())); InputStream input = ExchangeHelper.convertToMandatoryType(exchange, InputStream.class, graph); @@ -336,7 +336,7 @@ protected List createSignatureGenerator(Exchange exchange return null; } - exchange.getOut().setHeader(NUMBER_OF_SIGNING_KEYS, Integer.valueOf(sigSecretKeysWithPrivateKeyAndUserId.size())); + exchange.getMessage().setHeader(NUMBER_OF_SIGNING_KEYS, Integer.valueOf(sigSecretKeysWithPrivateKeyAndUserId.size())); List sigGens = new ArrayList<>(); for (PGPSecretKeyAndPrivateKeyAndUserId sigSecretKeyWithPrivateKeyAndUserId : sigSecretKeysWithPrivateKeyAndUserId) { diff --git a/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/processor/SigningProcessor.java b/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/processor/SigningProcessor.java index 32294c22a5537..0714da520991a 100644 --- a/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/processor/SigningProcessor.java +++ b/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/processor/SigningProcessor.java @@ -43,9 +43,7 @@ public void process(Exchange exchange) throws Exception { Message in = exchange.getIn(); clearMessageHeaders(in); - Message out = exchange.getOut(); - out.copyFrom(in); - out.setHeader(config.getSignatureHeaderName(), new Base64().encode(signature)); + exchange.getMessage().setHeader(config.getSignatureHeaderName(), new Base64().encode(signature)); } protected Signature initSignatureService(Exchange exchange) throws Exception { diff --git a/components/camel-fop/src/main/java/org/apache/camel/component/fop/FopProducer.java b/components/camel-fop/src/main/java/org/apache/camel/component/fop/FopProducer.java index 89c8f58084257..6b0f44ad2b5c3 100644 --- a/components/camel-fop/src/main/java/org/apache/camel/component/fop/FopProducer.java +++ b/components/camel-fop/src/main/java/org/apache/camel/component/fop/FopProducer.java @@ -64,10 +64,8 @@ public void process(Exchange exchange) throws Exception { Source src = exchange.getIn().getBody(StreamSource.class); OutputStream out = transform(userAgent, outputFormat, src); - exchange.getOut().setBody(out); - - // propagate headers - exchange.getOut().setHeaders(headers); + exchange.getMessage().setBody(out); + exchange.getMessage().setHeaders(headers); } private String getOutputFormat(Exchange exchange) { diff --git a/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7DataFormat.java b/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7DataFormat.java index 64f40446838d5..e1a1fe2631ee8 100644 --- a/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7DataFormat.java +++ b/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7DataFormat.java @@ -131,13 +131,13 @@ public Object unmarshal(Exchange exchange, InputStream inputStream) throws Excep String bodyAsString = new String(body, charsetName); Message message = parser.parse(bodyAsString); - // add MSH fields as message out headers + // add MSH fields as message headers Terser terser = new Terser(message); for (Map.Entry entry : HEADER_MAP.entrySet()) { - exchange.getOut().setHeader(entry.getKey(), terser.get(entry.getValue())); + exchange.getMessage().setHeader(entry.getKey(), terser.get(entry.getValue())); } - exchange.getOut().setHeader(HL7_CONTEXT, hapiContext); - exchange.getOut().setHeader(Exchange.CHARSET_NAME, charsetName); + exchange.getMessage().setHeader(HL7_CONTEXT, hapiContext); + exchange.getMessage().setHeader(Exchange.CHARSET_NAME, charsetName); return message; } diff --git a/components/camel-influxdb/src/main/java/org/apache/camel/component/influxdb/InfluxDbProducer.java b/components/camel-influxdb/src/main/java/org/apache/camel/component/influxdb/InfluxDbProducer.java index de98bff06eeb9..14ecc5d563bf4 100644 --- a/components/camel-influxdb/src/main/java/org/apache/camel/component/influxdb/InfluxDbProducer.java +++ b/components/camel-influxdb/src/main/java/org/apache/camel/component/influxdb/InfluxDbProducer.java @@ -19,7 +19,6 @@ import org.apache.camel.Exchange; import org.apache.camel.InvalidPayloadException; import org.apache.camel.support.DefaultProducer; -import org.apache.camel.support.MessageHelper; import org.apache.camel.util.ObjectHelper; import org.influxdb.InfluxDB; import org.influxdb.dto.BatchPoints; @@ -99,13 +98,11 @@ private void doQuery(Exchange exchange, String dataBaseName) { String query = calculateQuery(exchange); Query influxdbQuery = new Query(query, dataBaseName); QueryResult resultSet = connection.query(influxdbQuery); - MessageHelper.copyHeaders(exchange.getIn(), exchange.getOut(), true); exchange.getMessage().setBody(resultSet); } private void doPing(Exchange exchange) { Pong result = connection.ping(); - MessageHelper.copyHeaders(exchange.getIn(), exchange.getOut(), true); exchange.getMessage().setBody(result); } diff --git a/components/camel-influxdb2/src/main/java/org/apache/camel/component/influxdb2/InfluxDb2Producer.java b/components/camel-influxdb2/src/main/java/org/apache/camel/component/influxdb2/InfluxDb2Producer.java index 417414a552d00..469ec5035b5c7 100644 --- a/components/camel-influxdb2/src/main/java/org/apache/camel/component/influxdb2/InfluxDb2Producer.java +++ b/components/camel-influxdb2/src/main/java/org/apache/camel/component/influxdb2/InfluxDb2Producer.java @@ -28,7 +28,6 @@ import org.apache.camel.component.influxdb2.data.Record; import org.apache.camel.component.influxdb2.data.Records; import org.apache.camel.support.DefaultProducer; -import org.apache.camel.support.MessageHelper; import org.apache.camel.util.ObjectHelper; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -174,7 +173,6 @@ private void insertRecords(Exchange exchange, String orgName, String bucketName, private void doPing(Exchange exchange) { Boolean result = connection.ping(); - MessageHelper.copyHeaders(exchange.getIn(), exchange.getOut(), true); exchange.getMessage().setBody(result); } diff --git a/components/camel-jcr/src/main/java/org/apache/camel/component/jcr/JcrProducer.java b/components/camel-jcr/src/main/java/org/apache/camel/component/jcr/JcrProducer.java index c7f3c5aa86b8a..a8f0f4cb4d4a4 100644 --- a/components/camel-jcr/src/main/java/org/apache/camel/component/jcr/JcrProducer.java +++ b/components/camel-jcr/src/main/java/org/apache/camel/component/jcr/JcrProducer.java @@ -66,7 +66,7 @@ public void process(Exchange exchange) throws Exception { } } node.addMixin("mix:referenceable"); - exchange.getOut().setBody(node.getIdentifier()); + exchange.getMessage().setBody(node.getIdentifier()); session.save(); } else if (JcrConstants.JCR_GET_BY_ID.equals(operation)) { Node node = session.getNodeByIdentifier(exchange.getIn() diff --git a/components/camel-jooq/src/main/java/org/apache/camel/component/jooq/JooqProducer.java b/components/camel-jooq/src/main/java/org/apache/camel/component/jooq/JooqProducer.java index a31d16438429f..a9fbb5011bbf5 100644 --- a/components/camel-jooq/src/main/java/org/apache/camel/component/jooq/JooqProducer.java +++ b/components/camel-jooq/src/main/java/org/apache/camel/component/jooq/JooqProducer.java @@ -18,7 +18,6 @@ import org.apache.camel.Exchange; import org.apache.camel.Expression; -import org.apache.camel.Message; import org.apache.camel.support.DefaultProducer; import org.apache.camel.util.ObjectHelper; import org.jooq.Configuration; @@ -71,8 +70,7 @@ public void process(Exchange exchange) { result = context.fetch(querySQL); } - Message target = exchange.getPattern().isOutCapable() ? exchange.getOut() : exchange.getIn(); - target.setBody(result); + exchange.getMessage().setBody(result); break; case NONE: DSLContext context = DSL.using(dbConfig); diff --git a/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaConsumer.java b/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaConsumer.java index cd019ec8977d9..5e5e64d4aafdf 100644 --- a/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaConsumer.java +++ b/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaConsumer.java @@ -30,7 +30,6 @@ import org.apache.camel.ExchangePropertyKey; import org.apache.camel.Processor; import org.apache.camel.support.DefaultConsumer; -import org.apache.camel.support.ExchangeHelper; import org.apache.camel.util.IOHelper; import org.apache.mina.core.filterchain.DefaultIoFilterChainBuilder; import org.apache.mina.core.filterchain.IoFilter; @@ -385,7 +384,7 @@ private Exchange createExchange(IoSession session, Object payload) { exchange.getIn().setHeader(MinaConstants.MINA_IOSESSION, session); exchange.getIn().setHeader(MinaConstants.MINA_LOCAL_ADDRESS, session.getLocalAddress()); exchange.getIn().setHeader(MinaConstants.MINA_REMOTE_ADDRESS, session.getRemoteAddress()); - MinaPayloadHelper.setIn(exchange, payload); + MinaPayloadHelper.setPayload(exchange, payload); return exchange; } @@ -440,12 +439,7 @@ public void messageReceived(IoSession session, Object object) throws Exception { // If there's a response to send, send it. // boolean disconnect = getEndpoint().getConfiguration().isDisconnect(); - Object response; - if (exchange.hasOut()) { - response = MinaPayloadHelper.getOut(getEndpoint(), exchange); - } else { - response = MinaPayloadHelper.getIn(getEndpoint(), exchange); - } + Object response = MinaPayloadHelper.getResponsePayload(getEndpoint(), exchange); boolean failed = exchange.isFailed(); if (failed && !getEndpoint().getConfiguration().isTransferExchange()) { @@ -453,7 +447,7 @@ public void messageReceived(IoSession session, Object object) throws Exception { response = exchange.getException(); } else { // failed and no exception, must be a fault - response = exchange.getOut().getBody(); + response = exchange.getMessage().getBody(); } } @@ -466,12 +460,8 @@ public void messageReceived(IoSession session, Object object) throws Exception { } // should session be closed after complete? - Boolean close; - if (ExchangeHelper.isOutCapable(exchange)) { - close = exchange.getOut().getHeader(MinaConstants.MINA_CLOSE_SESSION_WHEN_COMPLETE, Boolean.class); - } else { - close = exchange.getIn().getHeader(MinaConstants.MINA_CLOSE_SESSION_WHEN_COMPLETE, Boolean.class); - } + Boolean close + = exchange.getMessage().getHeader(MinaConstants.MINA_CLOSE_SESSION_WHEN_COMPLETE, Boolean.class); // should we disconnect, the header can override the configuration if (close != null) { diff --git a/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaPayloadHelper.java b/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaPayloadHelper.java index b786ca9f45fbb..e700ac0ccbaa3 100644 --- a/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaPayloadHelper.java +++ b/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaPayloadHelper.java @@ -32,7 +32,7 @@ private MinaPayloadHelper() { //Utility Class } - public static Object getIn(MinaEndpoint endpoint, Exchange exchange) { + public static Object getRequestPayload(MinaEndpoint endpoint, Exchange exchange) { if (endpoint.getConfiguration().isTransferExchange()) { // we should transfer the entire exchange over the wire (includes in/out) return DefaultExchangeHolder.marshal(exchange); @@ -42,32 +42,22 @@ public static Object getIn(MinaEndpoint endpoint, Exchange exchange) { } } - public static Object getOut(MinaEndpoint endpoint, Exchange exchange) { + public static Object getResponsePayload(MinaEndpoint endpoint, Exchange exchange) { if (endpoint.getConfiguration().isTransferExchange()) { // we should transfer the entire exchange over the wire (includes in/out) return DefaultExchangeHolder.marshal(exchange); } else { // normal transfer using the body only - return exchange.getOut().getBody(); + return exchange.getMessage().getBody(); } } - public static void setIn(Exchange exchange, Object payload) { + public static void setPayload(Exchange exchange, Object payload) { if (payload instanceof DefaultExchangeHolder) { DefaultExchangeHolder.unmarshal(exchange, (DefaultExchangeHolder) payload); } else { // normal transfer using the body only - exchange.getIn().setBody(payload); - } - } - - public static void setOut(Exchange exchange, Object payload) { - if (payload instanceof DefaultExchangeHolder) { - DefaultExchangeHolder.unmarshal(exchange, (DefaultExchangeHolder) payload); - } else { - // normal transfer using the body only and preserve the headers - exchange.getOut().setHeaders(exchange.getIn().getHeaders()); - exchange.getOut().setBody(payload); + exchange.getMessage().setBody(payload); } } } diff --git a/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java b/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java index ddb26027906d5..d5ae0463131f3 100644 --- a/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java +++ b/components/camel-mina/src/main/java/org/apache/camel/component/mina/MinaProducer.java @@ -31,7 +31,6 @@ import org.apache.camel.ExchangeTimedOutException; import org.apache.camel.spi.CamelLogger; import org.apache.camel.support.DefaultProducer; -import org.apache.camel.support.ExchangeHelper; import org.apache.camel.util.IOHelper; import org.apache.mina.core.filterchain.DefaultIoFilterChainBuilder; import org.apache.mina.core.filterchain.IoFilter; @@ -136,7 +135,7 @@ protected void doProcess(Exchange exchange) throws Exception { IOHelper.normalizeCharset(getEndpoint().getConfiguration().getCharsetName())); } - Object body = MinaPayloadHelper.getIn(getEndpoint(), exchange); + Object body = MinaPayloadHelper.getRequestPayload(getEndpoint(), exchange); if (body == null) { noReplyLogger.log("No payload to send for exchange: " + exchange); return; // exit early since nothing to write @@ -184,12 +183,8 @@ protected void doProcess(Exchange exchange) throws Exception { maybeDisconnectOnTimeout(); throw new ExchangeTimedOutException(exchange, timeout); } else { - // set the result on either IN or OUT on the original exchange depending on its pattern - if (ExchangeHelper.isOutCapable(exchange)) { - MinaPayloadHelper.setOut(exchange, handler.getMessage()); - } else { - MinaPayloadHelper.setIn(exchange, handler.getMessage()); - } + // set the result on the exchange + MinaPayloadHelper.setPayload(exchange, handler.getMessage()); } } } @@ -210,12 +205,7 @@ protected void maybeDisconnectOnDone(Exchange exchange) throws InterruptedExcept } // should session be closed after complete? - Boolean close; - if (ExchangeHelper.isOutCapable(exchange)) { - close = exchange.getOut().getHeader(MinaConstants.MINA_CLOSE_SESSION_WHEN_COMPLETE, Boolean.class); - } else { - close = exchange.getIn().getHeader(MinaConstants.MINA_CLOSE_SESSION_WHEN_COMPLETE, Boolean.class); - } + Boolean close = exchange.getMessage().getHeader(MinaConstants.MINA_CLOSE_SESSION_WHEN_COMPLETE, Boolean.class); // should we disconnect, the header can override the configuration boolean disconnect = getEndpoint().getConfiguration().isDisconnect(); diff --git a/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockExpressionClause.java b/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockExpressionClause.java index 0138366f431e9..fa28b29fbadb6 100644 --- a/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockExpressionClause.java +++ b/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockExpressionClause.java @@ -125,7 +125,7 @@ public T outMessage(final Function function) { return delegate.expression(new ExpressionAdapter() { @Override public Object evaluate(Exchange exchange) { - return function.apply(exchange.getOut()); + return function.apply(exchange.getMessage()); } }); } @@ -215,7 +215,7 @@ public T outBody(final Function function) { return delegate.expression(new ExpressionAdapter() { @Override public Object evaluate(Exchange exchange) { - return function.apply(exchange.getOut().getBody()); + return function.apply(exchange.getMessage().getBody()); } }); } @@ -228,8 +228,8 @@ public T outBody(final BiFunction, Object> function) @Override public Object evaluate(Exchange exchange) { return function.apply( - exchange.getOut().getBody(), - exchange.getOut().getHeaders()); + exchange.getMessage().getBody(), + exchange.getMessage().getHeaders()); } }); } @@ -241,7 +241,7 @@ public T outBody(Class expectedType, final Function function) return delegate.expression(new ExpressionAdapter() { @Override public Object evaluate(Exchange exchange) { - return function.apply(exchange.getOut().getBody(expectedType)); + return function.apply(exchange.getMessage().getBody(expectedType)); } }); } @@ -254,8 +254,8 @@ public T outBody(Class expectedType, final BiFunction