Skip to content

Commit 59f2588

Browse files
authored
feat: change static ReadWriteLock to instance lock in SyncedEnforcer (#467)
1 parent f5e25e3 commit 59f2588

File tree

2 files changed

+126
-112
lines changed

2 files changed

+126
-112
lines changed

src/main/java/org/casbin/jcasbin/main/SyncedCachedEnforcer.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public class SyncedCachedEnforcer extends SyncedEnforcer{
3030
private Duration expireTime;
3131
private Cache cache;
3232
private final AtomicBoolean enableCache = new AtomicBoolean(true);
33-
private final static ReadWriteLock READ_WRITE_LOCK = new ReentrantReadWriteLock();
3433

3534
/**
3635
* Default constructor. Initializes a new SyncedCachedEnforcer with a default cache.
@@ -248,10 +247,10 @@ public boolean removePolicies(String[][] rules) {
248247
*/
249248
private Boolean getCachedResult(String key) {
250249
try {
251-
READ_WRITE_LOCK.readLock().lock();
250+
getReadWriteLock().readLock().lock();
252251
return cache.get(key);
253252
} finally {
254-
READ_WRITE_LOCK.readLock().unlock();
253+
getReadWriteLock().readLock().unlock();
255254
}
256255
}
257256

@@ -261,11 +260,11 @@ private Boolean getCachedResult(String key) {
261260
* @param expireTime The expiration time.
262261
*/
263262
public void setExpireTime(Duration expireTime) {
264-
READ_WRITE_LOCK.writeLock().lock();
263+
getReadWriteLock().writeLock().lock();
265264
try {
266265
this.expireTime = expireTime;
267266
} finally {
268-
READ_WRITE_LOCK.writeLock().unlock();
267+
getReadWriteLock().writeLock().unlock();
269268
}
270269
}
271270

@@ -275,11 +274,11 @@ public void setExpireTime(Duration expireTime) {
275274
* @param cache The custom cache.
276275
*/
277276
public void setCache(Cache cache) {
278-
READ_WRITE_LOCK.writeLock().lock();
277+
getReadWriteLock().writeLock().lock();
279278
try {
280279
this.cache = cache;
281280
} finally {
282-
READ_WRITE_LOCK.writeLock().unlock();
281+
getReadWriteLock().writeLock().unlock();
283282
}
284283
}
285284

0 commit comments

Comments
 (0)