Skip to content

Commit 2a20841

Browse files
committed
Raise server-side timeouts for TokenIT tests
1 parent ec38704 commit 2a20841

File tree

7 files changed

+54
-7
lines changed

7 files changed

+54
-7
lines changed

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/ByteOrderedTokenIT.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,14 @@
3636
public class ByteOrderedTokenIT extends TokenITBase {
3737

3838
private static final CustomCcmRule CCM_RULE =
39-
CustomCcmRule.builder().withNodes(3).withCreateOption("-p ByteOrderedPartitioner").build();
39+
CustomCcmRule.builder()
40+
.withNodes(3)
41+
.withCreateOption("-p ByteOrderedPartitioner")
42+
.withCassandraConfiguration("range_request_timeout_in_ms", 45_000)
43+
.withCassandraConfiguration("read_request_timeout_in_ms", 45_000)
44+
.withCassandraConfiguration("write_request_timeout_in_ms", 45_000)
45+
.withCassandraConfiguration("request_timeout_in_ms", 45_000)
46+
.build();
4047

4148
private static final SessionRule<CqlSession> SESSION_RULE =
4249
SessionRule.builder(CCM_RULE)

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/ByteOrderedTokenVnodesIT.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ public class ByteOrderedTokenVnodesIT extends TokenITBase {
4040
.withNodes(3)
4141
.withCreateOption("-p ByteOrderedPartitioner")
4242
.withCreateOption("--vnodes")
43+
.withCassandraConfiguration("range_request_timeout_in_ms", 45_000)
44+
.withCassandraConfiguration("read_request_timeout_in_ms", 45_000)
45+
.withCassandraConfiguration("write_request_timeout_in_ms", 45_000)
46+
.withCassandraConfiguration("request_timeout_in_ms", 45_000)
4347
.build();
4448

4549
private static final SessionRule<CqlSession> SESSION_RULE =

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/Murmur3TokenIT.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,14 @@
2929

3030
public class Murmur3TokenIT extends TokenITBase {
3131

32-
private static final CustomCcmRule CCM_RULE = CustomCcmRule.builder().withNodes(3).build();
32+
private static final CustomCcmRule CCM_RULE =
33+
CustomCcmRule.builder()
34+
.withNodes(3)
35+
.withCassandraConfiguration("range_request_timeout_in_ms", 45_000)
36+
.withCassandraConfiguration("read_request_timeout_in_ms", 45_000)
37+
.withCassandraConfiguration("write_request_timeout_in_ms", 45_000)
38+
.withCassandraConfiguration("request_timeout_in_ms", 45_000)
39+
.build();
3340

3441
private static final SessionRule<CqlSession> SESSION_RULE =
3542
SessionRule.builder(CCM_RULE)

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/Murmur3TokenVnodesIT.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,14 @@
3535
public class Murmur3TokenVnodesIT extends TokenITBase {
3636

3737
private static final CustomCcmRule CCM_RULE =
38-
CustomCcmRule.builder().withNodes(3).withCreateOption("--vnodes").build();
38+
CustomCcmRule.builder()
39+
.withNodes(3)
40+
.withCreateOption("--vnodes")
41+
.withCassandraConfiguration("range_request_timeout_in_ms", 45_000)
42+
.withCassandraConfiguration("read_request_timeout_in_ms", 45_000)
43+
.withCassandraConfiguration("write_request_timeout_in_ms", 45_000)
44+
.withCassandraConfiguration("request_timeout_in_ms", 45_000)
45+
.build();
3946

4047
private static final SessionRule<CqlSession> SESSION_RULE =
4148
SessionRule.builder(CCM_RULE)

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/RandomTokenIT.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,14 @@
3030
public class RandomTokenIT extends TokenITBase {
3131

3232
private static final CustomCcmRule CCM_RULE =
33-
CustomCcmRule.builder().withNodes(3).withCreateOption("-p RandomPartitioner").build();
33+
CustomCcmRule.builder()
34+
.withNodes(3)
35+
.withCreateOption("-p RandomPartitioner")
36+
.withCassandraConfiguration("range_request_timeout_in_ms", 45_000)
37+
.withCassandraConfiguration("read_request_timeout_in_ms", 45_000)
38+
.withCassandraConfiguration("write_request_timeout_in_ms", 45_000)
39+
.withCassandraConfiguration("request_timeout_in_ms", 45_000)
40+
.build();
3441

3542
private static final SessionRule<CqlSession> SESSION_RULE =
3643
SessionRule.builder(CCM_RULE)

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/RandomTokenVnodesIT.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ public class RandomTokenVnodesIT extends TokenITBase {
3939
.withNodes(3)
4040
.withCreateOption("-p RandomPartitioner")
4141
.withCreateOption("--vnodes")
42+
.withCassandraConfiguration("range_request_timeout_in_ms", 45_000)
43+
.withCassandraConfiguration("read_request_timeout_in_ms", 45_000)
44+
.withCassandraConfiguration("write_request_timeout_in_ms", 45_000)
45+
.withCassandraConfiguration("request_timeout_in_ms", 45_000)
4246
.build();
4347

4448
private static final SessionRule<CqlSession> SESSION_RULE =

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/TokenITBase.java

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ public void should_be_consistent_with_range_queries() {
102102
int key = 1;
103103
ProtocolVersion protocolVersion = session().getContext().getProtocolVersion();
104104
ByteBuffer serializedKey = TypeCodecs.INT.encodePrimitive(key, protocolVersion);
105+
assertThat(serializedKey).isNotNull();
105106
Set<Node> replicas = tokenMap.getReplicas(KS1, serializedKey);
106107
assertThat(replicas).hasSize(1);
107108
Node replica = replicas.iterator().next();
@@ -133,7 +134,7 @@ public void should_be_consistent_with_range_queries() {
133134
private List<Row> rangeQuery(PreparedStatement rangeStatement, TokenRange range) {
134135
List<Row> rows = Lists.newArrayList();
135136
for (TokenRange subRange : range.unwrap()) {
136-
Statement statement = rangeStatement.bind(subRange.getStart(), subRange.getEnd());
137+
Statement<?> statement = rangeStatement.bind(subRange.getStart(), subRange.getEnd());
137138
session().execute(statement).forEach(rows::add);
138139
}
139140
return rows;
@@ -156,10 +157,11 @@ private List<Row> rangeQuery(PreparedStatement rangeStatement, TokenRange range)
156157
public void should_get_token_from_row_and_set_token_in_query() {
157158
ResultSet rs = session().execute("SELECT token(i) FROM foo WHERE i = 1");
158159
Row row = rs.one();
160+
assertThat(row).isNotNull();
159161

160162
// Get by index:
161163
Token token = row.getToken(0);
162-
assertThat(token).isInstanceOf(expectedTokenType);
164+
assertThat(token).isNotNull().isInstanceOf(expectedTokenType);
163165

164166
// Get by name: the generated column name depends on the Cassandra version.
165167
String tokenColumnName =
@@ -173,10 +175,12 @@ public void should_get_token_from_row_and_set_token_in_query() {
173175

174176
// Bind with setToken by index
175177
row = session().execute(pst.bind().setToken(0, token)).one();
178+
assertThat(row).isNotNull();
176179
assertThat(row.getInt(0)).isEqualTo(1);
177180

178181
// Bind with setToken by name
179182
row = session().execute(pst.bind().setToken("partition key token", token)).one();
183+
assertThat(row).isNotNull();
180184
assertThat(row.getInt(0)).isEqualTo(1);
181185
}
182186

@@ -190,17 +194,20 @@ public void should_get_token_from_row_and_set_token_in_query() {
190194
@Test
191195
public void should_get_token_from_row_and_set_token_in_query_with_binding_and_aliasing() {
192196
Row row = session().execute("SELECT token(i) AS t FROM foo WHERE i = 1").one();
197+
assertThat(row).isNotNull();
193198
Token token = row.getToken("t");
194-
assertThat(token).isInstanceOf(expectedTokenType);
199+
assertThat(token).isNotNull().isInstanceOf(expectedTokenType);
195200

196201
PreparedStatement pst = session().prepare("SELECT * FROM foo WHERE token(i) = :myToken");
197202
row = session().execute(pst.bind().setToken("myToken", token)).one();
203+
assertThat(row).isNotNull();
198204
assertThat(row.getInt(0)).isEqualTo(1);
199205

200206
row =
201207
session()
202208
.execute(SimpleStatement.newInstance("SELECT * FROM foo WHERE token(i) = ?", token))
203209
.one();
210+
assertThat(row).isNotNull();
204211
assertThat(row.getInt(0)).isEqualTo(1);
205212
}
206213

@@ -216,6 +223,7 @@ public void should_get_token_from_row_and_set_token_in_query_with_binding_and_al
216223
@Test(expected = IllegalArgumentException.class)
217224
public void should_raise_exception_when_getting_token_on_non_token_column() {
218225
Row row = session().execute("SELECT i FROM foo WHERE i = 1").one();
226+
assertThat(row).isNotNull();
219227
row.getToken(0);
220228
}
221229

@@ -237,11 +245,13 @@ public void should_expose_consistent_ranges() {
237245
}
238246

239247
private void checkRanges(Session session) {
248+
assertThat(session.getMetadata().getTokenMap()).isPresent();
240249
TokenMap tokenMap = session.getMetadata().getTokenMap().get();
241250
checkRanges(tokenMap.getTokenRanges());
242251
}
243252

244253
private void checkRanges(Session session, CqlIdentifier keyspace, int replicationFactor) {
254+
assertThat(session.getMetadata().getTokenMap()).isPresent();
245255
TokenMap tokenMap = session.getMetadata().getTokenMap().get();
246256
List<TokenRange> allRangesWithDuplicates = Lists.newArrayList();
247257

@@ -347,6 +357,7 @@ public void should_create_token_from_partition_key() {
347357
TokenMap tokenMap = getTokenMap();
348358

349359
Row row = session().execute("SELECT token(i) FROM foo WHERE i = 1").one();
360+
assertThat(row).isNotNull();
350361
Token expected = row.getToken(0);
351362

352363
ProtocolVersion protocolVersion = session().getContext().getProtocolVersion();

0 commit comments

Comments
 (0)