Fix ThreadLocalReadAheadBufferTest to avoid FileNotFoundException when -Djava.io.tmpdir set to /tmp

isaacreath · smiklosovic · commit 170bf57eacbd · 2025-08-08T09:00:57.000+02:00
patch by Isaac Reath; reviewed by Paulo Motta, Stefan Miklosovic for CASSANDRA-20819
diff --git a/test/unit/org/apache/cassandra/io/util/ThreadLocalReadAheadBufferTest.java b/test/unit/org/apache/cassandra/io/util/ThreadLocalReadAheadBufferTest.java
@@ -177,13 +177,13 @@ public InputData(File file, List<Pair<Long, Integer>> positionsAndLengths)
 
     private static File writeFile(int seed, int length)
     {
-        String fileName = JAVA_IO_TMPDIR.getString() + "data+" + length + ".bin";
+        String fileName = "data+" + length + ".bin";
 
         byte[] dataChunk = new byte[4096 * 8];
         java.util.Random random = new Random(seed);
         int writtenData = 0;
 
-        File file = new File(fileName);
+        File file = new File(JAVA_IO_TMPDIR.getString(), fileName);
         try (FileOutputStream fos = new FileOutputStream(file.toJavaIOFile()))
         {
             while (writtenData < length)

Original file line number	Diff line number	Diff line change
`@@ -177,13 +177,13 @@ public InputData(File file, List<Pair<Long, Integer>> positionsAndLengths)`
`177`	`177`
`178`	`178`	`private static File writeFile(int seed, int length)`
`179`	`179`	`{`
`180`		`- String fileName = JAVA_IO_TMPDIR.getString() + "data+" + length + ".bin";`
	`180`	`+ String fileName = "data+" + length + ".bin";`
`181`	`181`
`182`	`182`	`byte[] dataChunk = new byte[4096 * 8];`
`183`	`183`	`java.util.Random random = new Random(seed);`
`184`	`184`	`int writtenData = 0;`
`185`	`185`
`186`		`- File file = new File(fileName);`
	`186`	`+ File file = new File(JAVA_IO_TMPDIR.getString(), fileName);`
`187`	`187`	`try (FileOutputStream fos = new FileOutputStream(file.toJavaIOFile()))`
`188`	`188`	`{`
`189`	`189`	`while (writtenData < length)`