Fix flakey test org.apache.cassandra.utils.SimpleBitSetSerializerTest

dcapwell · dcapwell · commit 28edf72bce13 · 2025-07-11T14:09:50.000-07:00
patch by David Capwell; reviewed by Benedict Elliott Smith, David Capwell for CASSANDRA-20759
diff --git a/test/unit/org/apache/cassandra/utils/SimpleBitSetSerializerTest.java b/test/unit/org/apache/cassandra/utils/SimpleBitSetSerializerTest.java
@@ -40,7 +40,7 @@ private static Gen<SimpleBitSet> simpleBitSetGen()
         return rs -> {
             int size = rs.nextInt(0, 1 << 10);
             SimpleBitSet bitSet = new SimpleBitSet(size);
-            if (rs.decide(0.2))
+            if (size == 0 || rs.decide(0.2))
                 return bitSet; // empty
             if (rs.decide(0.2))
             {

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ private static Gen<SimpleBitSet> simpleBitSetGen()`
`40`	`40`	`return rs -> {`
`41`	`41`	`int size = rs.nextInt(0, 1 << 10);`
`42`	`42`	`SimpleBitSet bitSet = new SimpleBitSet(size);`
`43`		`- if (rs.decide(0.2))`
	`43`	`+ if (size == 0 \|\| rs.decide(0.2))`
`44`	`44`	`return bitSet; // empty`
`45`	`45`	`if (rs.decide(0.2))`
`46`	`46`	`{`