Truncate mutation journal as logs get reconciled #4410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Aleksey Yeschenko; reviewed by Alex Petrov for CASSANDRA-20710
ifesdjeen
approved these changes
Oct 7, 2025
| into.add(segment.asStatic()); | ||
| } | ||
|
|
||
| void selectStatic(Predicate<StaticSegment<K, V>> filter, Collection<StaticSegment<K, V>> into) |
There was a problem hiding this comment.
Should we cache static segments to avoid re-filtering every time?
| } | ||
| }, | ||
| compactor(cfs, userVersion)); | ||
| this.journal = |
There was a problem hiding this comment.
Would be great to extract this portion of the patch and get it committed to trunk.
| if (index == null) | ||
| index = OnDiskIndex.rebuildAndPersist(descriptor, keySupport, metadata.fsyncLimit()); | ||
|
|
||
| KeyStats.Static<K> keyStats = keyStatsFactory.load(descriptor); |
There was a problem hiding this comment.
OffsetRangesFactory#load doesn't seem to have any path that would return null. Maybe instead of throwing JournalReadError we should log it and return null?
| public void truncateForTesting() | ||
| { | ||
| ActiveSegment<?, ?> discarding = currentSegment; | ||
| if (!discarding.isEmpty()) // if there is no data in the segement then ignore it |
There was a problem hiding this comment.
nit, and I know this is not your code, but segement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Aleksey Yeschenko; reviewed by Alex Petrov for CASSANDRA-20710