Fix excessive TOAST storage for AO row tables

avamingli · avamingli · commit 166ce1ec6ed4 · 2025-07-13T22:02:28.000+08:00
Customer reported that Cloudberry's AO row TOAST tables consume significantly more space compared to Greenplum 7. This issue was introduced by commit 0e819cf, which cherry-picked fixes from GPDB. Correct the parameter order to resolve the space inefficiency. Authored-by: Zhang Mingli avamingli@gmail.com
diff --git a/src/backend/access/heap/heaptoast.c b/src/backend/access/heap/heaptoast.c
@@ -106,7 +106,7 @@ heap_toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup, in
 MemTuple memtup_toast_insert_or_update(Relation rel, MemTuple newtup, MemTuple oldtup,
 									   MemTupleBinding *pbind, int toast_tuple_target, int options)
 {
-	return (MemTuple) heap_toast_insert_or_update_generic(rel, newtup, oldtup, pbind, toast_tuple_target, options, true);
+	return (MemTuple) heap_toast_insert_or_update_generic(rel, newtup, oldtup, pbind, options, toast_tuple_target, true);
 }
 
 static void *

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ heap_toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup, in`
`106`	`106`	`MemTuple memtup_toast_insert_or_update(Relation rel, MemTuple newtup, MemTuple oldtup,`
`107`	`107`	`MemTupleBinding *pbind, int toast_tuple_target, int options)`
`108`	`108`	`{`
`109`		`- return (MemTuple) heap_toast_insert_or_update_generic(rel, newtup, oldtup, pbind, toast_tuple_target, options, true);`
	`109`	`+ return (MemTuple) heap_toast_insert_or_update_generic(rel, newtup, oldtup, pbind, options, toast_tuple_target, true);`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`static void *`