Disable offsetnumber assertion in ginPostingListDecodeAllSegments()

Fix issue: #1222

As comments in itemptr_to_uint64:
Greenplum allow 16 bits for the offsetnumber, which turns the
below upstream assertion into an always-true comparison which
generates a compiler warning; thus we need to keep this commented out.

For sql in issue 1222, we will get assert failure as:

DETAIL:  FailedAssertion("!(((_Bool) ((( ((void) ((_Bool) (! (!(((_Bool)
(((const void*)(&segment->first) != ((void *)0)) &&
((&segment->first)->ip_posid != 0))))) ||
(ExceptionalCondition("!(((_Bool) (((const void*)(&segment->first) !=
((void *)0)) && ((&segment->first)->ip_posid != 0))))",
("FailedAssertion"), "ginpostinglist.c", 338), 0)))), (
(&segment->first)->ip_posid ) ) != ((OffsetNumber) 0)) && (( ((void)
((_Bool) (! (!(((_Bool) (((const void*)(&segment->first) != ((void *)0))
&& ((&segment->first)->ip_posid != 0))))) ||
(ExceptionalCondition("!(((_Bool) (((const void*)(&segment->first) !=
((void *)0)) && ((&segment->first)->ip_posid != 0))))",
("FailedAssertion"), "ginpostinglist.c", 338), 0)))), (
(&segment->first)->ip_posid ) ) <= ((OffsetNumber) (32768 /
sizeof(ItemIdData)))))))", File: "ginpostinglist.c", Line: 338)

Reported-by: assam258-5892 [email protected]
Reproduced-by: Zhang Mingli [email protected]
Authored-by: Zhang Mingli [email protected]

Author: avamingli

src/backend/access/gin/ginpostinglist.c

@@ -335,7 +335,13 @@ ginPostingListDecodeAllSegments(GinPostingList *segment, int len, int *ndecoded_
 		}
 
 		/* copy the first item */
+		/*
+		 * Keep this commented out.
+		 * See comments in itemptr_to_uint64().
+		 */
+#if 0
 		Assert(OffsetNumberIsValid(ItemPointerGetOffsetNumber(&segment->first)));
+#endif
 		Assert(ndecoded == 0 || ginCompareItemPointers(&segment->first, &result[ndecoded - 1]) > 0);
 		result[ndecoded] = segment->first;
 		ndecoded++;

src/test/regress/expected/gin.out

@@ -310,3 +310,12 @@ select count(*) from t_gin_test_tbl where j @> '{}'::int[];
 reset enable_seqscan;
 reset enable_bitmapscan;
 drop table t_gin_test_tbl;
+--
+-- Github issue: https://github.com/apache/cloudberry/issues/1222
+--
+begin;
+create table t_issue_1222(i int4[]) with (appendonly=true);
+create index t_issue_1222_idx on t_issue_1222 using gin (i)
+  with (fastupdate = on, gin_pending_list_limit = 4096);
+insert into t_issue_1222 select array[1, 2, g] from generate_series(1, 400000) g;
+abort;

src/test/regress/expected/gin_optimizer.out

@@ -308,3 +308,12 @@ select count(*) from t_gin_test_tbl where j @> '{}'::int[];
 reset enable_seqscan;
 reset enable_bitmapscan;
 drop table t_gin_test_tbl;
+--
+-- Github issue: https://github.com/apache/cloudberry/issues/1222
+--
+begin;
+create table t_issue_1222(i int4[]) with (appendonly=true);
+create index t_issue_1222_idx on t_issue_1222 using gin (i)
+  with (fastupdate = on, gin_pending_list_limit = 4096);
+insert into t_issue_1222 select array[1, 2, g] from generate_series(1, 400000) g;
+abort;

src/test/regress/sql/gin.sql

@@ -172,3 +172,13 @@ reset enable_seqscan;
 reset enable_bitmapscan;
 
 drop table t_gin_test_tbl;
+
+--
+-- Github issue: https://github.com/apache/cloudberry/issues/1222
+--
+begin;
+create table t_issue_1222(i int4[]) with (appendonly=true);
+create index t_issue_1222_idx on t_issue_1222 using gin (i)
+  with (fastupdate = on, gin_pending_list_limit = 4096);
+insert into t_issue_1222 select array[1, 2, g] from generate_series(1, 400000) g;
+abort;