Skip to content

Commit 897c057

Browse files
authored
Improve error message when COORDINATOR_DATA_DIRECTORY is unset
This commit updates gpstop and gpstart to use shared logic when determining the coordinator data directory. By relying on the common helper, users receive clearer and more actionable error messages when COORDINATOR_DATA_DIRECTORY is unset or invalid, making startup and shutdown failures easier to diagnose.
1 parent f35b332 commit 897c057

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

gpMgmt/bin/gpstart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -902,9 +902,7 @@ class GpStart:
902902

903903
if is_external_fts:
904904
if options.fts_hosts is None:
905-
coordinator_data_directory = os.getenv('COORDINATOR_DATA_DIRECTORY')
906-
if coordinator_data_directory is None:
907-
coordinator_data_directory = options.coordinatorDataDirectory
905+
coordinator_data_directory = gp.get_coordinatordatadir()
908906
options.fts_hosts = coordinator_data_directory + '/config' + '/fts_host'
909907

910908
return GpStart(options.specialMode, options.restricted,

gpMgmt/bin/gpstop

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -959,9 +959,7 @@ class GpStop:
959959

960960
if is_external_fts:
961961
if options.fts_hosts is None:
962-
coordinator_data_directory = os.getenv('COORDINATOR_DATA_DIRECTORY')
963-
if coordinator_data_directory is None:
964-
coordinator_data_directory = options.coordinatorDataDirectory
962+
coordinator_data_directory = gp.get_coordinatordatadir()
965963

966964
options.fts_hosts = coordinator_data_directory + '/config' + '/fts_host'
967965

0 commit comments

Comments
 (0)