Skip to content

Commit a59b30b

Browse files
reshkereshke
committed
Add more contrib extensions to ic-contrib-check
Also fix pgstattuple expected output.
1 parent 8bde32c commit a59b30b

File tree

3 files changed

+25
-12
lines changed

3 files changed

+25
-12
lines changed

‎.github/workflows/build-cloudberry.yml‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,14 +289,19 @@ jobs:
289289
"contrib/amcheck:installcheck",
290290
"contrib/citext:installcheck",
291291
"contrib/btree_gin:installcheck",
292+
"contrib/btree_gist:installcheck",
293+
"contrib/dblink:installcheck",
294+
"contrib/dict_int:installcheck",
295+
"contrib/dict_xsyn:installcheck",
296+
"contrib/extprotocol:installcheck",
292297
"contrib/file_fdw:installcheck",
293298
"contrib/formatter_fixedwidth:installcheck",
294-
"contrib/extprotocol:installcheck",
295-
"contrib/dblink:installcheck",
299+
"contrib/hstore:installcheck",
300+
"contrib/indexscan:installcheck",
296301
"contrib/pg_trgm:installcheck",
297302
"contrib/indexscan:installcheck",
298-
"contrib/hstore:installcheck",
299303
"contrib/pgcrypto:installcheck",
304+
"contrib/pgstattuple:installcheck",
300305
"contrib/tablefunc:installcheck",
301306
"contrib/passwordcheck:installcheck",
302307
"contrib/pg_buffercache:installcheck",

‎.github/workflows/build-deb-cloudberry.yml‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,14 +228,19 @@ jobs:
228228
"contrib/amcheck:installcheck",
229229
"contrib/citext:installcheck",
230230
"contrib/btree_gin:installcheck",
231+
"contrib/btree_gist:installcheck",
232+
"contrib/dblink:installcheck",
233+
"contrib/dict_int:installcheck",
234+
"contrib/dict_xsyn:installcheck",
235+
"contrib/extprotocol:installcheck",
231236
"contrib/file_fdw:installcheck",
232237
"contrib/formatter_fixedwidth:installcheck",
233-
"contrib/extprotocol:installcheck",
234-
"contrib/dblink:installcheck",
238+
"contrib/hstore:installcheck",
239+
"contrib/indexscan:installcheck",
235240
"contrib/pg_trgm:installcheck",
236241
"contrib/indexscan:installcheck",
237-
"contrib/hstore:installcheck",
238242
"contrib/pgcrypto:installcheck",
243+
"contrib/pgstattuple:installcheck",
239244
"contrib/tablefunc:installcheck",
240245
"contrib/passwordcheck:installcheck",
241246
"contrib/pg_buffercache:installcheck",

‎contrib/pgstattuple/expected/pgstattuple.out‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,16 +152,18 @@ select pgstatginindex('test_hashidx');
152152
ERROR: relation "test_hashidx" is not a GIN index
153153
-- check that using any of these functions with unsupported relations will fail
154154
create table test_partitioned (a int) partition by range (a);
155+
NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'a' as the Apache Cloudberry data distribution key for this table.
156+
HINT: The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
155157
create index test_partitioned_index on test_partitioned(a);
156158
-- these should all fail
157159
select pgstattuple('test_partitioned');
158160
ERROR: "test_partitioned" (partitioned table) is not supported
159161
select pgstattuple('test_partitioned_index');
160162
ERROR: "test_partitioned_index" (partitioned index) is not supported
161163
select pgstattuple_approx('test_partitioned');
162-
ERROR: "test_partitioned" is not a table, materialized view, or TOAST table
164+
ERROR: "test_partitioned" is not a table, directory table, materialized view, or TOAST table
163165
select pg_relpages('test_partitioned');
164-
ERROR: "test_partitioned" is not a table, index, materialized view, sequence, or TOAST table
166+
ERROR: "test_partitioned" is not a table, directory table, index, materialized view, sequence, or TOAST table
165167
select pgstatindex('test_partitioned');
166168
ERROR: relation "test_partitioned" is not a btree index
167169
select pgstatginindex('test_partitioned');
@@ -173,9 +175,9 @@ create view test_view as select 1;
173175
select pgstattuple('test_view');
174176
ERROR: "test_view" (view) is not supported
175177
select pgstattuple_approx('test_view');
176-
ERROR: "test_view" is not a table, materialized view, or TOAST table
178+
ERROR: "test_view" is not a table, directory table, materialized view, or TOAST table
177179
select pg_relpages('test_view');
178-
ERROR: "test_view" is not a table, index, materialized view, sequence, or TOAST table
180+
ERROR: "test_view" is not a table, directory table, index, materialized view, sequence, or TOAST table
179181
select pgstatindex('test_view');
180182
ERROR: relation "test_view" is not a btree index
181183
select pgstatginindex('test_view');
@@ -189,9 +191,9 @@ create foreign table test_foreign_table () server dummy_server;
189191
select pgstattuple('test_foreign_table');
190192
ERROR: "test_foreign_table" (foreign table) is not supported
191193
select pgstattuple_approx('test_foreign_table');
192-
ERROR: "test_foreign_table" is not a table, materialized view, or TOAST table
194+
ERROR: "test_foreign_table" is not a table, directory table, materialized view, or TOAST table
193195
select pg_relpages('test_foreign_table');
194-
ERROR: "test_foreign_table" is not a table, index, materialized view, sequence, or TOAST table
196+
ERROR: "test_foreign_table" is not a table, directory table, index, materialized view, sequence, or TOAST table
195197
select pgstatindex('test_foreign_table');
196198
ERROR: relation "test_foreign_table" is not a btree index
197199
select pgstatginindex('test_foreign_table');
@@ -200,6 +202,7 @@ select pgstathashindex('test_foreign_table');
200202
ERROR: "test_foreign_table" is not an index
201203
-- a partition of a partitioned table should work though
202204
create table test_partition partition of test_partitioned for values from (1) to (100);
205+
NOTICE: table has parent, setting distribution columns to match parent table
203206
select pgstattuple('test_partition');
204207
pgstattuple
205208
---------------------

0 commit comments

Comments
 (0)