Skip to content

Commit a5d00de

Browse files
ruhuang2001my-ship-it
authored andcommitted
Refactor cbdb_log to use vfprintf
Using vfprintf to avoid unnecessary buffer
1 parent d7b5762 commit a5d00de

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

src/fe_utils/log.c

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -97,28 +97,17 @@ cbdb_log(cbdb_log_level level, const char* file, int line, const char* format, .
9797
snprintf(timestamp, MAX_TIMESTAMP_LENGTH, "%s.%06ld", date, (long) tv.tv_usec);
9898

9999
// record timestamp, file name, and line num
100-
len = snprintf(NULL, 0, fmt, timestamp, s_level[level], file, line);
101-
if (len > 0)
102-
{
103-
char buffer[1000];
104-
snprintf(buffer, len + 1, fmt, timestamp, s_level[level], file, line);
105-
buffer[len] = 0;
106-
fprintf(log_file, "%s,", buffer);
107-
}
100+
fprintf(log_file, fmt, timestamp, s_level[level], file, line);
101+
fprintf(log_file, ",");
108102

109103
// record log information
110104
va_list arg_ptr;
111105
va_start(arg_ptr, format);
112-
len = vsnprintf(NULL, 0, format, arg_ptr);
106+
len = vfprintf(log_file, format, arg_ptr);
113107
va_end(arg_ptr);
114108
if (len > 0)
115109
{
116-
char buffer[1000];
117-
va_start(arg_ptr, format);
118-
vsnprintf(buffer, len + 1, format, arg_ptr);
119-
va_end(arg_ptr);
120-
buffer[len] = 0;
121-
fprintf(log_file, "%s\n", buffer);
110+
fprintf(log_file, "\n");
122111
}
123112

124113
cur_line_num ++;

0 commit comments

Comments
 (0)