Skip to content

Commit cb28adc

Browse files
committed
Fix orca permission checking
Fix obvious bug, which leads to coredump. Permission checking still needs to be adjusted to satisfy initplan permission checking
1 parent 130aef2 commit cb28adc

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/backend/gpopt/translate/CTranslatorQueryToDXL.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,7 @@ CTranslatorQueryToDXL::TranslateInsertQueryToDXL()
862862
GPOS_WSZ_LIT("Inserts with foreign tables"));
863863
}
864864
const RTEPermissionInfo *perminfo = gpdb::GetRTEPermissionInfo(
865-
m_query->rtable, rte);
865+
m_query->rteperminfos, rte);
866866

867867
CDXLTableDescr *table_descr = CTranslatorUtils::GetTableDescr(
868868
m_mp, m_md_accessor, m_context->m_colid_counter, rte, perminfo, m_query_id,
@@ -1188,7 +1188,7 @@ CTranslatorQueryToDXL::TranslateDeleteQueryToDXL()
11881188
GPOS_WSZ_LIT("Deletes with foreign tables"));
11891189
}
11901190
const RTEPermissionInfo *perminfo = gpdb::GetRTEPermissionInfo(
1191-
m_query->rtable, rte);
1191+
m_query->rteperminfos, rte);
11921192

11931193
CDXLTableDescr *table_descr = CTranslatorUtils::GetTableDescr(
11941194
m_mp, m_md_accessor, m_context->m_colid_counter, rte, perminfo, m_query_id,
@@ -1273,7 +1273,7 @@ CTranslatorQueryToDXL::TranslateUpdateQueryToDXL()
12731273
GPOS_WSZ_LIT("Updates with foreign tables"));
12741274
}
12751275
const RTEPermissionInfo *perminfo = gpdb::GetRTEPermissionInfo(
1276-
m_query->rtable, rte);
1276+
m_query->rteperminfos, rte);
12771277

12781278
CDXLTableDescr *table_descr = CTranslatorUtils::GetTableDescr(
12791279
m_mp, m_md_accessor, m_context->m_colid_counter, rte, perminfo, m_query_id,
@@ -3266,7 +3266,7 @@ CTranslatorQueryToDXL::TranslateFromClauseToDXL(Node *node)
32663266
GPOS_WSZ_LIT("WITH ORDINALITY"));
32673267
}
32683268

3269-
const RTEPermissionInfo *perminfo = gpdb::GetRTEPermissionInfo(m_query->rtable,
3269+
const RTEPermissionInfo *perminfo = gpdb::GetRTEPermissionInfo(m_query->rteperminfos,
32703270
rte);
32713271

32723272
switch (rte->rtekind)

0 commit comments

Comments
 (0)