Fix compile issue for higher version of gcc/g++

1. return std::move(temp_value) will report error in high version of g++,
    keep the behavior align with higher version of g++.
2. remove some maybe uninitialized varible.
3. add -Wno-error=array-bounds, so protobuf header will not report errors.

Author: gfphoenix78

contrib/pax_storage/CMakeLists.txt

@@ -21,7 +21,7 @@ set(CMAKE_CXX_STANDARD 17)
 set(TOP_DIR ${PROJECT_SOURCE_DIR}/../..)
 set(CBDB_INCLUDE_DIR ${TOP_DIR}/src/include)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Werror -Wno-unused-function -Wno-error=ignored-qualifiers -Wuninitialized -Winit-self -Wstrict-aliasing -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered -Wno-sized-deallocation -g")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Werror -Werror=pessimizing-move  -Wno-unused-function -Wno-error=ignored-qualifiers -Wno-error=array-bounds  -Wuninitialized -Winit-self -Wstrict-aliasing -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered -Wno-sized-deallocation -g")
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wno-unused-parameter -Wno-parameter-name")
 
 option(USE_MANIFEST_API "Use manifest API" OFF)

contrib/pax_storage/src/cpp/storage/micro_partition_iterator.cc

@@ -164,7 +164,7 @@ MicroPartitionMetadata MicroPartitionInfoIterator::Next() {
   Assert(tuple);
 
   tuple_ = nullptr;
-  return std::move(ToValue(tuple));
+  return ToValue(tuple);
 }
 
 void MicroPartitionInfoIterator::Rewind() {
@@ -375,7 +375,7 @@ MicroPartitionMetadata MicroPartitionInfoParallelIterator::Next() {
   Assert(tuple);
 
   tuple_ = nullptr;
-  return std::move(ToValue(tuple));
+  return ToValue(tuple);
 }
 
 void MicroPartitionInfoParallelIterator::Rewind() {

contrib/pax_storage/src/cpp/storage/micro_partition_stats.cc

@@ -173,7 +173,6 @@ static bool PrepareStatisticsInfoCombine(
 
     auto attr = TupleDescAttr(desc, i);
     auto collation = attr->attcollation;
-    FmgrInfo finfo;
     bool get_pg_oper_succ = false;
 
     funcs.emplace_back(std::make_pair(nullptr, nullptr));
@@ -207,7 +206,6 @@ static bool PrepareStatisticsInfoCombine(
 
       GetStrategyProcinfo(attr->atttypid, attr->atttypid, funcs[i]);
       if (allow_fallback_to_pg) {
-        finfos[i] = {finfo, finfo};
         get_pg_oper_succ =
             GetStrategyProcinfo(attr->atttypid, attr->atttypid, finfos[i]);
       }

contrib/pax_storage/src/cpp/storage/toast/pax_toast.cc

@@ -331,7 +331,7 @@ static std::pair<Datum, std::shared_ptr<MemoryObject>> pax_make_external_toast(
 std::pair<Datum, std::shared_ptr<MemoryObject>> pax_make_toast(
     Datum d, char storage_type) {
   std::shared_ptr<MemoryObject> mobj;
-  Datum result;
+  Datum result = d;
 
   if (!pax_enable_toast) {
     return {d, nullptr};