From 134a5d58e52ab0d7ed3c4be127e9fac64245bb2b Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Mon, 4 Aug 2025 18:10:06 +0530 Subject: [PATCH 1/2] config: fix access for config and history file Fixes #157 Signed-off-by: Abhishek Kumar --- config/config.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/config/config.go b/config/config.go index 52ee9f0..8664827 100644 --- a/config/config.go +++ b/config/config.go @@ -263,6 +263,7 @@ func saveConfig(cfg *Config) *Config { conf.Section(defaultCoreConfig.ProfileName).ReflectFrom(&defaultProfile) conf.SaveTo(cfg.ConfigFile) } + makeFileGroupPrivate(cfg.ConfigFile) conf := readConfig(cfg) @@ -318,6 +319,10 @@ func saveConfig(cfg *Config) *Config { profiles = append(profiles, profile.Name()) } + if cfg.HistoryFile != "" { + makeFileGroupPrivate(cfg.HistoryFile) + } + return cfg } @@ -391,6 +396,12 @@ func (c *Config) UpdateConfig(key string, value string, update bool) { } } +func makeFileGroupPrivate(filePath string) { + if fi, err := os.Stat(filePath); err == nil && fi.Mode().IsRegular() { + _ = os.Chmod(filePath, 0660) + } +} + // NewConfig creates or reload config and loads API cache func NewConfig(configFilePath *string) *Config { defaultConf := defaultConfig() From b2929d0e9b2bc435972ef61f8553d074c8065178 Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Wed, 6 Aug 2025 17:35:32 +0530 Subject: [PATCH 2/2] fix Signed-off-by: Abhishek Kumar --- config/config.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/config/config.go b/config/config.go index 8664827..15e1088 100644 --- a/config/config.go +++ b/config/config.go @@ -263,7 +263,7 @@ func saveConfig(cfg *Config) *Config { conf.Section(defaultCoreConfig.ProfileName).ReflectFrom(&defaultProfile) conf.SaveTo(cfg.ConfigFile) } - makeFileGroupPrivate(cfg.ConfigFile) + makeFileUserPrivate(cfg.ConfigFile) conf := readConfig(cfg) @@ -320,7 +320,7 @@ func saveConfig(cfg *Config) *Config { } if cfg.HistoryFile != "" { - makeFileGroupPrivate(cfg.HistoryFile) + makeFileUserPrivate(cfg.HistoryFile) } return cfg @@ -396,9 +396,11 @@ func (c *Config) UpdateConfig(key string, value string, update bool) { } } -func makeFileGroupPrivate(filePath string) { +func makeFileUserPrivate(filePath string) { if fi, err := os.Stat(filePath); err == nil && fi.Mode().IsRegular() { - _ = os.Chmod(filePath, 0660) + if err := os.Chmod(filePath, 0600); err != nil { + fmt.Printf("Failed to set permissions on %s: %v\n", filePath, err) + } } }