login: allow 2fa code input if mandated #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#145 Signed-off-by: Abhishek Kumar <[email protected]>
shwstppr
requested review from
DaanHoogland,
harikrishna-patnala,
rohityadavcloud and
weizhouapache
weizhouapache
approved these changes
Aug 7, 2025
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
nice improvement
Signed-off-by: Abhishek Kumar <[email protected]>
|
✅ Build complete for PR #175. 🔗 Download the cmk binaries (expires on August 18, 2025) |
DaanHoogland
approved these changes
Aug 11, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, tested static pin and totp
shwstppr
added a commit
to shwstppr/cloudstack-cloudmonkey
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
cmk-2fa.mp4