Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 29, 2024

Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr shwstppr changed the title Feature webhooks feature: webhooks Feb 29, 2024
@apache apache deleted a comment from blueorangutan Feb 29, 2024
@apache apache deleted a comment from blueorangutan Feb 29, 2024
Signed-off-by: Abhishek Kumar <[email protected]>
@apache apache deleted a comment from blueorangutan Feb 29, 2024
@apache apache deleted a comment from blueorangutan Feb 29, 2024
@shwstppr
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 218)

@shwstppr shwstppr mentioned this pull request Feb 29, 2024
13 tasks
@DaanHoogland
Copy link
Contributor

@shwstppr , if I search for webhooks I get both a hit on the events page and a separate page. Is that on purpose? These seem to contain the same text.

also:
image
I think the text "|create-webhooks.png|"/link should not be there, but the picture should be embedded.

@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 8, 2024

@blueorangutan docbuild

@DaanHoogland I'm not sure about the way search works on the documentation website but since webhooks-related notes are in a separate .rst file, it could be the reason two search entries are showing.
I've added a fix for image not showing

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 221)

@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 8, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 223)

@shwstppr
Copy link
Contributor Author

shwstppr commented May 1, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 230)

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , the documentation looks good

@shwstppr shwstppr marked this pull request as ready for review June 5, 2024 11:09
@shwstppr shwstppr marked this pull request as draft June 5, 2024 11:14
@rohityadavcloud rohityadavcloud marked this pull request as ready for review June 7, 2024 09:43
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge this when the linked PR is merged.

@rohityadavcloud rohityadavcloud added this to the 4.20 milestone Jun 7, 2024
@rohityadavcloud rohityadavcloud merged commit e5bc36d into apache:main Jun 10, 2024
@rohityadavcloud rohityadavcloud deleted the feature-webhooks branch June 10, 2024 05:10
GaOrtiga pushed a commit to GaOrtiga/cloudstack-documentation that referenced this pull request Jun 28, 2024
* feature: webhooks

Documentation for apache/cloudstack#8674

* changes

Signed-off-by: Abhishek Kumar <[email protected]>

* changes

Signed-off-by: Abhishek Kumar <[email protected]>

* changes

Signed-off-by: Abhishek Kumar <[email protected]>

* Update source/adminguide/events/webhooks.rst

* note regarding duplicate event deliveries

Signed-off-by: Abhishek Kumar <[email protected]>

* note on self-signed https payload url

Signed-off-by: Abhishek Kumar <[email protected]>

---------

Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants