Skip to content

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented May 1, 2024

@vishesh92 vishesh92 force-pushed the enforce-strict-host-tag-check branch from c5e4ae9 to 9dff7ce Compare May 1, 2024 17:05
@vishesh92
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/398. (QA-JID 231)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as per the changes in apache/cloudstack#9017

@vishesh92
Copy link
Member Author

@andrijapanicsb I have updated the documentation. Please review again.

@andrijapanicsb
Copy link
Contributor

I think it makes more sense now, yes. Thanks Vishesh.

Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rohityadavcloud pushed a commit to apache/cloudstack that referenced this pull request Jun 25, 2024
Documentation PR: apache/cloudstack-documentation#398

Currently, an administrator can break host tag compatibility for a VM administrator by certain operations:
* deploy/start VM on a specific host
* migrate VM
* restore VM
* scale VM

This PR allows the user to specify tags which must be checked during these operations.

Global Settings
1. `vm.strict.host.tags` - A comma-separated list of tags for strict host check (Default - empty)
2. `vm.strict.resource.limit.host.tag.check` - Determines whether the resource limits tags are considered strict or not (Default - true)

During the above operations, we now check and throw an error if host tags compatibility is being broken for tags specified in `vm.strict.host.tags`. If `vm.strict.resource.limit.host.tag.check` is set to `true`, tags set in `resource.limit.host.tags` are also checked during these operations.
@rohityadavcloud rohityadavcloud added this to the 4.20 milestone Jun 25, 2024
@rohityadavcloud rohityadavcloud marked this pull request as ready for review June 25, 2024 09:12
@rohityadavcloud rohityadavcloud merged commit a8a7bf4 into apache:main Jun 25, 2024
GaOrtiga pushed a commit to GaOrtiga/cloudstack-documentation that referenced this pull request Jun 28, 2024
* Update documentation for strict host tags

* Address comments
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
Documentation PR: apache/cloudstack-documentation#398

Currently, an administrator can break host tag compatibility for a VM administrator by certain operations:
* deploy/start VM on a specific host
* migrate VM
* restore VM
* scale VM

This PR allows the user to specify tags which must be checked during these operations.

Global Settings
1. `vm.strict.host.tags` - A comma-separated list of tags for strict host check (Default - empty)
2. `vm.strict.resource.limit.host.tag.check` - Determines whether the resource limits tags are considered strict or not (Default - true)

During the above operations, we now check and throw an error if host tags compatibility is being broken for tags specified in `vm.strict.host.tags`. If `vm.strict.resource.limit.host.tag.check` is set to `true`, tags set in `resource.limit.host.tags` are also checked during these operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants