Skip to content

Commit 2584bd3

Browse files
Updated required params for create VPC, and generate changes
1 parent 9164e3c commit 2584bd3

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

cloudstack/UserService.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3133,7 +3133,7 @@ func (s *UserService) NewVerifyOAuthCodeAndGetUserParams(provider string) *Verif
31333133

31343134
// Verify the OAuth Code and fetch the corresponding user from provider
31353135
func (s *UserService) VerifyOAuthCodeAndGetUser(p *VerifyOAuthCodeAndGetUserParams) (*VerifyOAuthCodeAndGetUserResponse, error) {
3136-
resp, err := s.cs.newPostRequest("verifyOAuthCodeAndGetUser", p.toURLValues())
3136+
resp, err := s.cs.newRequest("verifyOAuthCodeAndGetUser", p.toURLValues())
31373137
if err != nil {
31383138
return nil, err
31393139
}

cloudstack/VPCService.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type VPCServiceIface interface {
3333
CreateStaticRoute(p *CreateStaticRouteParams) (*CreateStaticRouteResponse, error)
3434
NewCreateStaticRouteParams(cidr string, gatewayid string) *CreateStaticRouteParams
3535
CreateVPC(p *CreateVPCParams) (*CreateVPCResponse, error)
36-
NewCreateVPCParams(displaytext string, name string, vpcofferingid string, zoneid string) *CreateVPCParams
36+
NewCreateVPCParams(cidr string, displaytext string, name string, vpcofferingid string, zoneid string) *CreateVPCParams
3737
CreateVPCOffering(p *CreateVPCOfferingParams) (*CreateVPCOfferingResponse, error)
3838
NewCreateVPCOfferingParams(displaytext string, name string) *CreateVPCOfferingParams
3939
DeletePrivateGateway(p *DeletePrivateGatewayParams) (*DeletePrivateGatewayResponse, error)
@@ -1045,9 +1045,10 @@ func (p *CreateVPCParams) GetZoneid() (string, bool) {
10451045

10461046
// You should always use this function to get a new CreateVPCParams instance,
10471047
// as then you are sure you have configured all required params
1048-
func (s *VPCService) NewCreateVPCParams(displaytext string, name string, vpcofferingid string, zoneid string) *CreateVPCParams {
1048+
func (s *VPCService) NewCreateVPCParams(cidr string, displaytext string, name string, vpcofferingid string, zoneid string) *CreateVPCParams {
10491049
p := &CreateVPCParams{}
10501050
p.p = make(map[string]interface{})
1051+
p.p["cidr"] = cidr
10511052
p.p["displaytext"] = displaytext
10521053
p.p["name"] = name
10531054
p.p["vpcofferingid"] = vpcofferingid

cloudstack/VPCService_mock.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

generate/requiredParams.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,11 @@ var requiredParams = map[string][]string{
4949
"displaytext",
5050
},
5151
"createVPC": {
52+
"name",
5253
"displaytext",
54+
"vpcofferingid",
55+
"zoneid",
56+
"cidr",
5357
},
5458
"createVPCOffering": {
5559
"displaytext",

test/VPCService_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func TestVPCService(t *testing.T) {
6969
if _, ok := response["createVPC"]; !ok {
7070
t.Skipf("Skipping as no json response is provided in testdata")
7171
}
72-
p := client.VPC.NewCreateVPCParams("displaytext", "name", "vpcofferingid", "zoneid")
72+
p := client.VPC.NewCreateVPCParams("cidr", "displaytext", "name", "vpcofferingid", "zoneid")
7373
r, err := client.VPC.CreateVPC(p)
7474
if err != nil {
7575
t.Errorf(err.Error())

0 commit comments

Comments
 (0)