Force some param to be required (#79)

Force parameters to be required to maintain backward compatability

Author: vishesh92

Makefile

@@ -14,7 +14,7 @@ SHELL = /usr/bin/env bash -o pipefail
 all: code mocks test
 
 code:
-	go run generate/generate.go generate/layout.go --api=generate/listApis.json
+	go run generate/generate.go generate/layout.go generate/requiredParams.go --api=generate/listApis.json
 
 FILES=$(shell for file in `pwd`/cloudstack/*Service.go ;do basename $$file .go ; done)
 mocks:

cloudstack/DiskOfferingService.go

@@ -29,7 +29,7 @@ import (
 
 type DiskOfferingServiceIface interface {
 	CreateDiskOffering(p *CreateDiskOfferingParams) (*CreateDiskOfferingResponse, error)
-	NewCreateDiskOfferingParams(name string) *CreateDiskOfferingParams
+	NewCreateDiskOfferingParams(displaytext string, name string) *CreateDiskOfferingParams
 	DeleteDiskOffering(p *DeleteDiskOfferingParams) (*DeleteDiskOfferingResponse, error)
 	NewDeleteDiskOfferingParams(id string) *DeleteDiskOfferingParams
 	ListDiskOfferings(p *ListDiskOfferingsParams) (*ListDiskOfferingsResponse, error)
@@ -639,9 +639,10 @@ func (p *CreateDiskOfferingParams) GetZoneid() ([]string, bool) {
 
 // You should always use this function to get a new CreateDiskOfferingParams instance,
 // as then you are sure you have configured all required params
-func (s *DiskOfferingService) NewCreateDiskOfferingParams(name string) *CreateDiskOfferingParams {
+func (s *DiskOfferingService) NewCreateDiskOfferingParams(displaytext string, name string) *CreateDiskOfferingParams {
 	p := &CreateDiskOfferingParams{}
 	p.p = make(map[string]interface{})
+	p.p["displaytext"] = displaytext
 	p.p["name"] = name
 	return p
 }

cloudstack/DiskOfferingService_mock.go

@@ -47,7 +47,7 @@ type ISOServiceIface interface {
 	GetIsoByName(name string, isofilter string, zoneid string, opts ...OptionFunc) (*Iso, int, error)
 	GetIsoByID(id string, opts ...OptionFunc) (*Iso, int, error)
 	RegisterIso(p *RegisterIsoParams) (*RegisterIsoResponse, error)
-	NewRegisterIsoParams(name string, url string, zoneid string) *RegisterIsoParams
+	NewRegisterIsoParams(displaytext string, name string, url string, zoneid string) *RegisterIsoParams
 	UpdateIso(p *UpdateIsoParams) (*UpdateIsoResponse, error)
 	NewUpdateIsoParams(id string) *UpdateIsoParams
 	UpdateIsoPermissions(p *UpdateIsoPermissionsParams) (*UpdateIsoPermissionsResponse, error)
@@ -2082,9 +2082,10 @@ func (p *RegisterIsoParams) GetZoneid() (string, bool) {
 
 // You should always use this function to get a new RegisterIsoParams instance,
 // as then you are sure you have configured all required params
-func (s *ISOService) NewRegisterIsoParams(name string, url string, zoneid string) *RegisterIsoParams {
+func (s *ISOService) NewRegisterIsoParams(displaytext string, name string, url string, zoneid string) *RegisterIsoParams {
 	p := &RegisterIsoParams{}
 	p.p = make(map[string]interface{})
+	p.p["displaytext"] = displaytext
 	p.p["name"] = name
 	p.p["url"] = url
 	p.p["zoneid"] = zoneid

cloudstack/ISOService.go

@@ -29,7 +29,7 @@ import (
 
 type NetworkOfferingServiceIface interface {
 	CreateNetworkOffering(p *CreateNetworkOfferingParams) (*CreateNetworkOfferingResponse, error)
-	NewCreateNetworkOfferingParams(guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams
+	NewCreateNetworkOfferingParams(displaytext string, guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams
 	DeleteNetworkOffering(p *DeleteNetworkOfferingParams) (*DeleteNetworkOfferingResponse, error)
 	NewDeleteNetworkOfferingParams(id string) *DeleteNetworkOfferingParams
 	ListNetworkOfferings(p *ListNetworkOfferingsParams) (*ListNetworkOfferingsResponse, error)
@@ -530,9 +530,10 @@ func (p *CreateNetworkOfferingParams) GetZoneid() ([]string, bool) {
 
 // You should always use this function to get a new CreateNetworkOfferingParams instance,
 // as then you are sure you have configured all required params
-func (s *NetworkOfferingService) NewCreateNetworkOfferingParams(guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams {
+func (s *NetworkOfferingService) NewCreateNetworkOfferingParams(displaytext string, guestiptype string, name string, traffictype string) *CreateNetworkOfferingParams {
 	p := &CreateNetworkOfferingParams{}
 	p.p = make(map[string]interface{})
+	p.p["displaytext"] = displaytext
 	p.p["guestiptype"] = guestiptype
 	p.p["name"] = name
 	p.p["traffictype"] = traffictype

cloudstack/ISOService_mock.go

@@ -35,7 +35,7 @@ type ProjectServiceIface interface {
 	AddUserToProject(p *AddUserToProjectParams) (*AddUserToProjectResponse, error)
 	NewAddUserToProjectParams(projectid string, username string) *AddUserToProjectParams
 	CreateProject(p *CreateProjectParams) (*CreateProjectResponse, error)
-	NewCreateProjectParams(name string) *CreateProjectParams
+	NewCreateProjectParams(displaytext string, name string) *CreateProjectParams
 	DeleteAccountFromProject(p *DeleteAccountFromProjectParams) (*DeleteAccountFromProjectResponse, error)
 	NewDeleteAccountFromProjectParams(account string, projectid string) *DeleteAccountFromProjectParams
 	DeleteUserFromProject(p *DeleteUserFromProjectParams) (*DeleteUserFromProjectResponse, error)
@@ -612,9 +612,10 @@ func (p *CreateProjectParams) GetUserid() (string, bool) {
 
 // You should always use this function to get a new CreateProjectParams instance,
 // as then you are sure you have configured all required params
-func (s *ProjectService) NewCreateProjectParams(name string) *CreateProjectParams {
+func (s *ProjectService) NewCreateProjectParams(displaytext string, name string) *CreateProjectParams {
 	p := &CreateProjectParams{}
 	p.p = make(map[string]interface{})
+	p.p["displaytext"] = displaytext
 	p.p["name"] = name
 	return p
 }

cloudstack/NetworkOfferingService.go

@@ -29,7 +29,7 @@ import (
 
 type ServiceOfferingServiceIface interface {
 	CreateServiceOffering(p *CreateServiceOfferingParams) (*CreateServiceOfferingResponse, error)
-	NewCreateServiceOfferingParams(name string) *CreateServiceOfferingParams
+	NewCreateServiceOfferingParams(displaytext string, name string) *CreateServiceOfferingParams
 	DeleteServiceOffering(p *DeleteServiceOfferingParams) (*DeleteServiceOfferingResponse, error)
 	NewDeleteServiceOfferingParams(id string) *DeleteServiceOfferingParams
 	ListServiceOfferings(p *ListServiceOfferingsParams) (*ListServiceOfferingsResponse, error)
@@ -940,9 +940,10 @@ func (p *CreateServiceOfferingParams) GetZoneid() ([]string, bool) {
 
 // You should always use this function to get a new CreateServiceOfferingParams instance,
 // as then you are sure you have configured all required params
-func (s *ServiceOfferingService) NewCreateServiceOfferingParams(name string) *CreateServiceOfferingParams {
+func (s *ServiceOfferingService) NewCreateServiceOfferingParams(displaytext string, name string) *CreateServiceOfferingParams {
 	p := &CreateServiceOfferingParams{}
 	p.p = make(map[string]interface{})
+	p.p["displaytext"] = displaytext
 	p.p["name"] = name
 	return p
 }