Skip to content

Commit e285bd0

Browse files
authored
Move fix to code generator (#40)
Co-authored-by: Vladimir DOMBROVSKI <[email protected]>
1 parent c73beb5 commit e285bd0

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

cloudstack/ResourcetagsService.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ func (p *DeleteTagsParams) toURLValues() url.Values {
196196
m := v.(map[string]string)
197197
for i, k := range getSortedKeysFromMap(m) {
198198
u.Set(fmt.Sprintf("tags[%d].key", i), k)
199-
u.Set(fmt.Sprintf("tags[%d].value", i), m[k])
199+
if m[k] != "" {
200+
u.Set(fmt.Sprintf("tags[%d].value", i), m[k])
201+
}
200202
}
201203
}
202204
return u

generate/generate.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1310,6 +1310,15 @@ func (s *service) generateConvertCode(cmd, name, typ string) {
13101310
case "usersecuritygrouplist":
13111311
pn(" u.Set(fmt.Sprintf(\"%s[%%d].account\", i), k)", name)
13121312
pn(" u.Set(fmt.Sprintf(\"%s[%%d].group\", i), m[k])", name)
1313+
case "tags":
1314+
pn(" u.Set(fmt.Sprintf(\"%s[%%d].key\", i), k)", name)
1315+
if cmd == "deleteTags" {
1316+
pn(" if m[k] != \"\" {")
1317+
pn(" u.Set(fmt.Sprintf(\"%s[%%d].value\", i), m[k])", name)
1318+
pn(" }")
1319+
} else {
1320+
pn(" u.Set(fmt.Sprintf(\"%s[%%d].value\", i), m[k])", name)
1321+
}
13131322
default:
13141323
pn(" u.Set(fmt.Sprintf(\"%s[%%d].key\", i), k)", name)
13151324
pn(" u.Set(fmt.Sprintf(\"%s[%%d].value\", i), m[k])", name)

0 commit comments

Comments
 (0)