-
Notifications
You must be signed in to change notification settings - Fork 37
Fix VM Usage history response #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Pearl1594 Changes looks good and the dependent PR is also merged. Can you resolve the conflicts? |
|
@vishesh92 - this would need 4.20.2 to be released. As the upstream fix isn't in 4.21. So I'll wait for the release to update the listApis file |
28c7fb8 to
4428802
Compare
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
Tested again. It's working as expected after the changes. |
Fixes: #97
Depends on: apache/cloudstack#10152