Minor fixups

Author: vishesh92

.golangci.yml

@@ -7,6 +7,10 @@ linters:
     - goheader
     - gosec
     - misspell
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
   settings:
     goheader:
       template: |-

Makefile

@@ -42,21 +42,21 @@ clean:
 cloudstack-ccm: ${CMD_SRC}
 	go build -ldflags ${LDFLAGS} -o $@ $^
 
-test:
+test: gofmt
 	go test -v
 	go vet
-	@(echo "gofmt -l"; FMTFILES="$$(gofmt -l .)"; if test -n "$${FMTFILES}"; then echo "Go files that need to be reformatted (use 'go fmt'):\n$${FMTFILES}"; exit 1; fi)
 
-docker:
+docker: gofmt
 	docker build . -t apache/cloudstack-kubernetes-provider:${GIT_COMMIT_SHORT}
 	docker tag apache/cloudstack-kubernetes-provider:${GIT_COMMIT_SHORT} apache/cloudstack-kubernetes-provider:latest
 ifneq (${GIT_IS_TAG},NOT_A_TAG)
 	docker tag apache/cloudstack-kubernetes-provider:${GIT_COMMIT_SHORT} apache/cloudstack-kubernetes-provider:${GIT_TAG}
 endif
 
-lint:
+lint: gofmt
 	@(echo "Running golangci-lint...")
 	golangci-lint run
+
+gofmt:
 	@(echo "Running gofmt...")
 	@(echo "gofmt -l"; FMTFILES="$$(gofmt -l .)"; if test -n "$${FMTFILES}"; then echo "Go files that need to be reformatted (use 'go fmt'):\n$${FMTFILES}"; exit 1; fi)
-

README.md

@@ -161,7 +161,7 @@ If you don't have a 'real' CloudStack installation, you can also launch a local
 ### Debugging
 
 You can use the VSCode extension [Go](https://marketplace.visualstudio.com/items?itemName=golang.go) to debug the CCM.
-Add the following configuration to the `.vscode/launch.json` file use it to launch the CCM.
+Add the following configuration to the `.vscode/launch.json` file to launch the CCM and debug it.
 
 ```json
 {
@@ -179,7 +179,7 @@ Add the following configuration to the `.vscode/launch.json` file use it to laun
                 "--cloud-config=${workspaceFolder}/cloud-config",
                 "--kubeconfig=${env:HOME}/.kube/config",
                 "--leader-elect=false",
-                "--v=5"
+                "--v=4"
             ],
             "showLog": true,
             "trace": "verbose"