Fix for service.beta.kubernetes.io/cloudstack-load-balancer-proxy-protocol #74
Conversation
As per source code, annotation should be having a value of 'true' or 'false' and not enabled. The existing examples are incorrect. service.beta.kubernetes.io/cloudstack-load-balancer-proxy-protocol: 'true'
As per source code, annotation should be having a value of 'true' or 'false' and not enabled. The existing examples are incorrect. service.beta.kubernetes.io/cloudstack-load-balancer-proxy-protocol: 'true'
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
Not tested it yet
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect annotation values in Kubernetes service configurations for the CloudStack load balancer proxy protocol. The annotation service.beta.kubernetes.io/cloudstack-load-balancer-proxy-protocol was using the value enabled, which is not recognized by the CloudStack provider code. According to the source code (specifically getBoolFromServiceAnnotation in cloudstack_loadbalancer.go), this annotation only accepts 'true' or 'false' as valid boolean string values.
- Corrects annotation value from
enabledto'true'in both configuration files - Ensures the annotation will be properly parsed by the
getBoolFromServiceAnnotationfunction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| traefik-ingress-controller.yml | Fixed proxy protocol annotation value from enabled to 'true' |
| nginx-ingress-controller-patch.yml | Fixed proxy protocol annotation value from enabled to 'true' |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
As per source code, annotation should be having a value of 'true' or 'false' and not enabled. The existing examples are incorrect.
service.beta.kubernetes.io/cloudstack-load-balancer-proxy-protocol: 'true'