Update debugging docs, GitHub Actions and golangci config #84
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the project's development tooling and documentation by updating GitHub Actions workflows to latest versions, overhauling the golangci-lint configuration to v2 format, adding local linting capabilities via Makefile, and enhancing developer documentation with debugging instructions.
Key Changes:
- Updated GitHub Actions to use
checkout@v6,setup-go@v6, andgolangci-lint-action@v9for better CI/CD reliability - Migrated
.golangci.ymlto version 2 configuration format with refined linter selection - Added VSCode debugging configuration and improved example usage in documentation
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build.yml |
Updated to ubuntu-latest, checkout@v6, and setup-go@v6 |
.github/workflows/build-docker-image.yml |
Updated to ubuntu-latest and checkout@v6 |
.github/workflows/golangci-lint.yml |
Updated actions to v6 and golangci-lint-action to v9 |
.golangci.yml |
Migrated to v2 config format with new linter settings and exclusions |
Makefile |
Added lint target for local code quality checks |
README.md |
Updated Go version requirement to 1.23 and added VSCode debugging section |
cloudstack_loadbalancer.go |
Standardized error messages to start with lowercase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| modules-download-mode: readonly | ||
| timeout: 5m | ||
| issues-exit-code: 1 | ||
| settings: |
There was a problem hiding this comment.
The settings key should be nested under linters, not at the top level. In golangci-lint v2 configuration format, linter-specific settings should be under linters.settings. This configuration should be:
linters:
enable:
- goheader
- gosec
- misspell
settings:
goheader:
template: |-
...1 participant
This pull request updates the project's development tooling and documentation to improve compatibility, maintainability, and developer experience. The most significant changes are updates to GitHub Actions workflows and
golangci-lintconfiguration, the addition of alinttarget to theMakefile, and enhancements to the documentation for building and debugging.CI/CD and Linting Improvements:
ubuntu-latest,actions/checkout@v6, andactions/setup-go@v6, and upgradedgolangci-lint-actionto v9 for improved reliability and support. (.github/workflows/build.yml,.github/workflows/build-docker-image.yml,.github/workflows/golangci-lint.yml) [1] [2] [3].golangci.yml: switched to version 2 config format, enabled/disabled specific linters, and added exclusions for generated code and certain paths for more precise linting. [1] [2]linttarget to theMakefileto rungolangci-lintandgofmt, improving local code quality checks.Documentation Updates:
README.mdto reflect current build requirements.launch.jsonconfiguration for easier local development.Minor Code Quality Fixes:
cloudstack_loadbalancer.gofor consistency.