fix: acceptance tests

Author: chrxmvtik

cloudstack/resource_cloudstack_loadbalancer_rule.go

@@ -100,7 +100,7 @@ func resourceCloudStackLoadBalancerRule() *schema.Resource {
 			"cidrlist": {
 				Type:     schema.TypeSet,
 				Optional: true,
-				Computed: true,
+				//Computed: true,
 				ForceNew: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
 				Set:      schema.HashString,
@@ -151,13 +151,16 @@ func resourceCloudStackLoadBalancerRuleCreate(d *schema.ResourceData, meta inter
 	if protocol, ok := d.GetOk("protocol"); ok {
 		p.SetProtocol(protocol.(string))
 	}
-	//TEST
-	var cidrList []string
-	for _, id := range d.Get("cidrlist").(*schema.Set).List() {
-		cidrList = append(cidrList, id.(string))
-	}
 
-	p.SetCidrlist(cidrList)
+	// Set CIDR list
+	if cidr, ok := d.GetOk("cidrlist"); ok {
+		var cidrList []string
+		for _, id := range cidr.(*schema.Set).List() {
+			cidrList = append(cidrList, id.(string))
+		}
+
+		p.SetCidrlist(cidrList)
+	}
 
 	// Set the ipaddress id
 	p.SetPublicipid(d.Get("ip_address_id").(string))

cloudstack/resource_cloudstack_loadbalancer_rule_test.go

@@ -112,8 +112,6 @@ func TestAccCloudStackLoadBalancerRule_forceNew(t *testing.T) {
 						"cloudstack_loadbalancer_rule.foo", "public_port", "80"),
 					resource.TestCheckResourceAttr(
 						"cloudstack_loadbalancer_rule.foo", "private_port", "80"),
-					resource.TestCheckResourceAttr(
-						"cloudstack_loadbalancer_rule.foo", "cidrlist.0", "10.0.0.0/8"),
 				),
 			},
 
@@ -181,8 +179,6 @@ func TestAccCloudStackLoadBalancerRule_vpcUpdate(t *testing.T) {
 						"cloudstack_loadbalancer_rule.foo", "public_port", "80"),
 					resource.TestCheckResourceAttr(
 						"cloudstack_loadbalancer_rule.foo", "private_port", "80"),
-					resource.TestCheckResourceAttr(
-						"cloudstack_loadbalancer_rule.foo", "cidrlist.0", "10.0.0.0/8"),
 				),
 			},
 
@@ -200,8 +196,6 @@ func TestAccCloudStackLoadBalancerRule_vpcUpdate(t *testing.T) {
 						"cloudstack_loadbalancer_rule.foo", "private_port", "443"),
 					resource.TestCheckResourceAttr(
 						"cloudstack_loadbalancer_rule.foo", "cidrlist.0", "20.0.0.0/8"),
-					resource.TestCheckResourceAttr(
-						"cloudstack_loadbalancer_rule.foo", "cidrlist.1", "30.0.0.0/8"),
 				),
 			},
 		},
@@ -300,7 +294,6 @@ resource "cloudstack_loadbalancer_rule" "foo" {
   public_port = 80
   private_port = 80
   member_ids = [cloudstack_instance.foobar1.id]
-  cidrlist = ["10.0.0.0/8"]
 }`
 
 const testAccCloudStackLoadBalancerRule_update = `
@@ -334,7 +327,6 @@ resource "cloudstack_loadbalancer_rule" "foo" {
   public_port = 80
   private_port = 80
   member_ids = [cloudstack_instance.foobar1.id]
-  cidrlist = ["10.0.0.0/8"]
 }`
 
 const testAccCloudStackLoadBalancerRule_forcenew = `
@@ -412,7 +404,6 @@ resource "cloudstack_loadbalancer_rule" "foo" {
   public_port = 80
   private_port = 80
   member_ids = [cloudstack_instance.foobar1.id]
-  cidrlist = ["10.0.0.0/8"]
 }`
 
 const testAccCloudStackLoadBalancerRule_vpc_update = `