add forceNew if the policy is modified to recreate the resource + fix test

Author: Pearl1594

cloudstack/resource_cloudstack_snapshot_policy.go

@@ -27,6 +27,21 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
+func intervalTypeToString(intervalType int) string {
+	switch intervalType {
+	case 0:
+		return "hourly"
+	case 1:
+		return "daily"
+	case 2:
+		return "weekly"
+	case 3:
+		return "monthly"
+	default:
+		return fmt.Sprintf("%d", intervalType)
+	}
+}
+
 func resourceCloudStackSnapshotPolicy() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceCloudstackSnapshotPolicyCreate,
@@ -38,26 +53,32 @@ func resourceCloudStackSnapshotPolicy() *schema.Resource {
 			"volume_id": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 			"interval_type": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 			"max_snaps": {
 				Type:     schema.TypeInt,
 				Required: true,
+				ForceNew: true,
 			},
 			"schedule": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 			"timezone": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 			"zone_ids": {
 				Type:     schema.TypeList,
 				Optional: true,
+				ForceNew: true,
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
 				},
@@ -150,7 +171,7 @@ func resourceCloudstackSnapshotPolicyRead(d *schema.ResourceData, meta interface
 	snapshotPolicy := resp.SnapshotPolicies[0]
 
 	d.Set("volume_id", snapshotPolicy.Volumeid)
-	d.Set("interval_type", snapshotPolicy.Intervaltype)
+	d.Set("interval_type", intervalTypeToString(snapshotPolicy.Intervaltype))
 	d.Set("max_snaps", snapshotPolicy.Maxsnaps)
 	d.Set("schedule", snapshotPolicy.Schedule)
 	d.Set("timezone", snapshotPolicy.Timezone)

cloudstack/resource_cloudstack_snapshot_policy_test.go

@@ -234,7 +234,7 @@ resource "cloudstack_disk" "foo" {
 
 resource "cloudstack_snapshot_policy" "foo" {
   volume_id     = cloudstack_disk.foo.id
-  interval_type = 1
+  interval_type = "DAILY"
   max_snaps     = 7
   schedule      = "02:30"
   timezone      = "UTC"
@@ -345,7 +345,7 @@ resource "cloudstack_disk" "foo" {
 
 resource "cloudstack_snapshot_policy" "hourly" {
   volume_id     = cloudstack_disk.foo.id
-  interval_type = 0
+  interval_type = "HOURLY"
   max_snaps     = 6
   schedule      = "0"
   timezone      = "UTC"
@@ -396,7 +396,7 @@ resource "cloudstack_disk" "foo" {
 
 resource "cloudstack_snapshot_policy" "weekly" {
   volume_id     = cloudstack_disk.foo.id
-  interval_type = 2
+  interval_type = "WEEKLY"
   max_snaps     = 4
   schedule      = "1:03:00"  # Monday at 3:00 AM
   timezone      = "UTC"
@@ -446,7 +446,7 @@ resource "cloudstack_disk" "foo" {
 
 resource "cloudstack_snapshot_policy" "monthly" {
   volume_id     = cloudstack_disk.foo.id
-  interval_type = 3
+  interval_type = "MONTHLY"
   max_snaps     = 12
   schedule      = "15:01:00"  # 15th day at 1:00 AM
   timezone      = "UTC"