chore(tests): remove ExpectNonEmptyPlan

As those are single tests, create and data source getting the value on the same execution, the plan after apply is expected to be empty (unless Cloudstack returns some change on the API)

Author: fabiomatavelli

cloudstack/data_source_cloudstack_instance_test.go

@@ -40,7 +40,6 @@ func TestAccInstanceDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "display_name", resourceName, "display_name"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_ipaddress_test.go

@@ -38,7 +38,6 @@ func TestAccIPAddressDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "zone_name", resourceName, "zone"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_network_offering_test.go

@@ -38,7 +38,6 @@ func TestAccNetworkOfferingDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_service_offering_test.go

@@ -38,7 +38,6 @@ func TestAccServiceOfferingDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_ssh_keypair_test.go

@@ -38,7 +38,6 @@ func TestAccSshKeyPairDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "id", resourceName, "id"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_user_test.go

@@ -38,7 +38,6 @@ func TestAccUserDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "first_name", resourceName, "first_name"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_volume_test.go

@@ -38,7 +38,6 @@ func TestAccVolumeDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})

cloudstack/data_source_cloudstack_zone_test.go

@@ -38,7 +38,6 @@ func TestAccZoneDataSource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})