Update params options

Author: poddm

cloudstack/data_source_cloudstack_zone.go

@@ -87,7 +87,7 @@ func dataSourceCloudstackZoneRead(d *schema.ResourceData, meta interface{}) erro
 }
 
 func zoneDescriptionAttributes(d *schema.ResourceData, zone *cloudstack.Zone) error {
-	d.SetId(zone.Name)
+	d.SetId(zone.Id)
 	d.Set("name", zone.Name)
 	d.Set("dns1", zone.Dns1)
 	d.Set("internal_dns1", zone.Internaldns1)

cloudstack/resource_cloudstack_physical_network.go

@@ -40,18 +40,22 @@ func resourceCloudStackPhysicalNetwork() *schema.Resource {
 			"broadcast_domain_range": {
 				Type:     schema.TypeString,
 				Optional: true,
+				ForceNew: true,
 			},
 			"domain_id": {
 				Type:     schema.TypeString,
 				Optional: true,
+				ForceNew: true,
 			},
 			"isolation_methods": {
 				Type:     schema.TypeString,
 				Optional: true,
+				ForceNew: true,
 			},
 			"name": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 			"network_speed": {
 				Type:     schema.TypeString,
@@ -68,6 +72,7 @@ func resourceCloudStackPhysicalNetwork() *schema.Resource {
 			"zone_id": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 		},
 	}

cloudstack/resource_cloudstack_physical_network_test.go

@@ -56,7 +56,7 @@ resource "cloudstack_physical_network" "test" {
 	name                   = "test01"
 	network_speed          = "1G"
 	tags                   = "vlan"
-	zone_id                 = cloudstack_zone.test.id
+	zone_id                = cloudstack_zone.test.id
 }
 `
 

cloudstack/resource_cloudstack_secondary_storage.go

@@ -0,0 +1,114 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+	"fmt"
+
+	"github.com/apache/cloudstack-go/v2/cloudstack"
+	"github.com/hashicorp/terraform/helper/schema"
+)
+
+func resourceCloudStackSecondaryStorage() *schema.Resource {
+	return &schema.Resource{
+		Create: resourceCloudStackSecondaryStorageCreate,
+		Read:   resourceCloudStackSecondaryStorageRead,
+		Delete: resourceCloudStackSecondaryStorageDelete,
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
+		Schema: map[string]*schema.Schema{
+			"name": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+				ForceNew: true,
+			},
+			"storage_provider": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+			"url": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+				ForceNew: true,
+			},
+			"zone_id": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+				ForceNew: true,
+			},
+		},
+	}
+}
+
+func resourceCloudStackSecondaryStorageCreate(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+
+	p := cs.ImageStore.NewAddImageStoreParams(d.Get("storage_provider").(string))
+	if v, ok := d.GetOk("name"); ok {
+		p.SetName(v.(string))
+	}
+	if v, ok := d.GetOk("url"); ok {
+		p.SetUrl(v.(string))
+	}
+	if v, ok := d.GetOk("zone_id"); ok {
+		p.SetZoneid(v.(string))
+	}
+
+	r, err := cs.ImageStore.AddImageStore(p)
+	if err != nil {
+		return err
+	}
+
+	d.SetId(r.Id)
+
+	return resourceCloudStackSecondaryStorageRead(d, meta)
+}
+
+func resourceCloudStackSecondaryStorageRead(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+
+	r, _, err := cs.ImageStore.GetImageStoreByID(d.Id())
+	if err != nil {
+		return err
+	}
+
+	d.Set("name", r.Name)
+	d.Set("storage_provider", r.Providername)
+	d.Set("url", r.Url)
+	d.Set("zone_id", r.Zoneid)
+
+	return nil
+}
+
+func resourceCloudStackSecondaryStorageDelete(d *schema.ResourceData, meta interface{}) error {
+	cs := meta.(*cloudstack.CloudStackClient)
+
+	_, err := cs.ImageStore.DeleteImageStore(cs.ImageStore.NewDeleteImageStoreParams(d.Id()))
+	if err != nil {
+		return fmt.Errorf("Error deleting secondary storage: %s", err)
+	}
+
+	return nil
+}

cloudstack/resource_cloudstack_secondary_storage_test.go

@@ -0,0 +1,53 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccCloudStackSecondaryStorage_basic(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCloudStackSecondaryStorage_basic,
+			},
+		},
+	})
+}
+
+const testAccCloudStackSecondaryStorage_basic = `
+data "cloudstack_zone" "test" {
+	filter {
+		name  = "name"
+		value = "Sandbox-simulator"
+	}
+}
+resource "cloudstack_secondary_storage" "test" {
+	name             = "acctest_secondarystorage"
+	storage_provider = "NFS"
+	url              = "nfs://10.147.28.6:/export/home/sandbox/secondary"
+	zone_id          = data.cloudstack_zone.test.id
+}
+`