fix: update PreCheck functions to use quota support checks in quota-related tests

Author: jean

cloudstack/data_source_cloudstack_quota_test.go

@@ -23,6 +23,7 @@ import (
 	"fmt"
 	"testing"
 
+	"github.com/apache/cloudstack-go/v2/cloudstack"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 )
@@ -31,7 +32,7 @@ func TestAccCloudStackQuotaDataSource_basic(t *testing.T) {
 	resourceName := "data.cloudstack_quota.test"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
+		PreCheck:  func() { testAccPreCheckQuotaSupport(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
@@ -49,7 +50,7 @@ func TestAccCloudStackQuotaDataSource_withFilters(t *testing.T) {
 	resourceName := "data.cloudstack_quota.test"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
+		PreCheck:  func() { testAccPreCheckQuotaSupport(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
@@ -67,7 +68,7 @@ func TestAccCloudStackQuotaEnabledDataSource_basic(t *testing.T) {
 	resourceName := "data.cloudstack_quota_enabled.test"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
+		PreCheck:  func() { testAccPreCheckQuotaSupport(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
@@ -85,7 +86,7 @@ func TestAccCloudStackQuotaTariffDataSource_basic(t *testing.T) {
 	resourceName := "data.cloudstack_quota_tariff.test"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
+		PreCheck:  func() { testAccPreCheckQuotaSupport(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
@@ -103,7 +104,7 @@ func TestAccCloudStackQuotaTariffDataSource_withFilters(t *testing.T) {
 	resourceName := "data.cloudstack_quota_tariff.test"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
+		PreCheck:  func() { testAccPreCheckQuotaSupport(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
@@ -163,6 +164,18 @@ func testAccCheckCloudStackQuotaTariffDataSourceExists(n string) resource.TestCh
 	}
 }
 
+func testAccPreCheckQuotaSupport(t *testing.T) {
+	testAccPreCheck(t)
+	cs := testAccProvider.Meta().(*cloudstack.CloudStackClient)
+
+	// Try to check if quota is enabled to verify if the feature is available
+	p := cs.Quota.NewQuotaIsEnabledParams()
+	_, err := cs.Quota.QuotaIsEnabled(p)
+	if err != nil {
+		t.Skipf("Quota feature not supported or not enabled in this CloudStack instance: %v", err)
+	}
+}
+
 // Test configuration functions
 func testAccCloudStackQuotaDataSource_basic() string {
 	return `

cloudstack/resource_cloudstack_quota_tariff_test.go

@@ -33,7 +33,7 @@ func TestAccCloudStackQuotaTariff_basic(t *testing.T) {
 	var quotaTariff cloudstack.QuotaTariffList
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck:     func() { testAccPreCheckQuotaSupport(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudStackQuotaTariffDestroy,
 		Steps: []resource.TestStep{
@@ -54,7 +54,7 @@ func TestAccCloudStackQuotaTariff_update(t *testing.T) {
 	var quotaTariff cloudstack.QuotaTariffList
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck:     func() { testAccPreCheckQuotaSupport(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudStackQuotaTariffDestroy,
 		Steps: []resource.TestStep{
@@ -83,7 +83,7 @@ func TestAccCloudStackQuotaTariff_import(t *testing.T) {
 	resourceName := "cloudstack_quota_tariff.test"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck:     func() { testAccPreCheckQuotaSupport(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudStackQuotaTariffDestroy,
 		Steps: []resource.TestStep{
@@ -179,7 +179,7 @@ resource "cloudstack_quota_tariff" "test" {
 // Test validation errors
 func TestAccCloudStackQuotaTariff_validation(t *testing.T) {
 	resource.Test(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
+		PreCheck:  func() { testAccPreCheckQuotaSupport(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
@@ -199,7 +199,7 @@ func TestAccCloudStackQuotaTariff_activationRules(t *testing.T) {
 	var quotaTariff cloudstack.QuotaTariffList
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck:     func() { testAccPreCheckQuotaSupport(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudStackQuotaTariffDestroy,
 		Steps: []resource.TestStep{
@@ -219,7 +219,7 @@ func TestAccCloudStackQuotaTariff_complexActivationRules(t *testing.T) {
 	var quotaTariff cloudstack.QuotaTariffList
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck:     func() { testAccPreCheckQuotaSupport(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudStackQuotaTariffDestroy,
 		Steps: []resource.TestStep{