do not enforce passing port when proto is 'all'

Pearl1594 · Pearl1594 · commit ad83bdee3b1e · 2025-10-07T12:14:13.000-04:00
diff --git a/cloudstack/resource_cloudstack_network_acl_rule.go b/cloudstack/resource_cloudstack_network_acl_rule.go
@@ -294,7 +294,9 @@ func createNetworkACLRule(d *schema.ResourceData, meta interface{}, rule map[str
 		}
 		log.Printf("[WARN] 'ports' is deprecated. Use 'port' instead.")
 	} else {
-		return fmt.Errorf("Parameter port is required for protocol 'tcp' or 'udp'. Use 'port' (string) for new configs.")
+		if rule["protocol"].(string) == "tcp" || rule["protocol"].(string) == "udp" {
+			return fmt.Errorf("Parameter port is required for protocol 'tcp' or 'udp'. Use 'port' (string) for new configs.")
+		}
 	}
 	if portStr != "" {
 		m := splitPorts.FindStringSubmatch(portStr)

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,9 @@ func createNetworkACLRule(d *schema.ResourceData, meta interface{}, rule map[str`
`294`	`294`	`}`
`295`	`295`	`log.Printf("[WARN] 'ports' is deprecated. Use 'port' instead.")`
`296`	`296`	`} else {`
`297`		`- return fmt.Errorf("Parameter port is required for protocol 'tcp' or 'udp'. Use 'port' (string) for new configs.")`
	`297`	`+ if rule["protocol"].(string) == "tcp" \|\| rule["protocol"].(string) == "udp" {`
	`298`	`+ return fmt.Errorf("Parameter port is required for protocol 'tcp' or 'udp'. Use 'port' (string) for new configs.")`
	`299`	`+ }`
`298`	`300`	`}`
`299`	`301`	`if portStr != "" {`
`300`	`302`	`m := splitPorts.FindStringSubmatch(portStr)`