fix test

Author: Pearl1594

cloudstack/data_source_cloudstack_network_offering.go

@@ -54,6 +54,64 @@ func dataSourceCloudstackNetworkOffering() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+			"network_rate": {
+				Type:     schema.TypeInt,
+				Computed: true,
+			},
+			"network_mode": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"conserve_mode": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"enable": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"for_vpc": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"for_nsx": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"specify_vlan": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"specify_ip_ranges": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"specify_as_number": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"internet_protocol": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"routing_mode": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"max_connections": {
+				Type:     schema.TypeInt,
+				Computed: true,
+			},
+			"supported_services": {
+				Type:     schema.TypeSet,
+				Computed: true,
+				Elem:     &schema.Schema{Type: schema.TypeString},
+			},
+			"service_provider_list": {
+				Type:     schema.TypeMap,
+				Computed: true,
+				Elem:     &schema.Schema{Type: schema.TypeString},
+			},
 		},
 	}
 }
@@ -100,6 +158,38 @@ func networkOfferingDescriptionAttributes(d *schema.ResourceData, networkOfferin
 	d.Set("display_text", networkOffering.Displaytext)
 	d.Set("guest_ip_type", networkOffering.Guestiptype)
 	d.Set("traffic_type", networkOffering.Traffictype)
+	d.Set("network_rate", networkOffering.Networkrate)
+	d.Set("network_mode", networkOffering.Networkmode)
+	d.Set("conserve_mode", networkOffering.Conservemode)
+	d.Set("enable", networkOffering.State == "Enabled")
+	d.Set("for_vpc", networkOffering.Forvpc)
+	d.Set("for_nsx", networkOffering.Fornsx)
+	d.Set("specify_vlan", networkOffering.Specifyvlan)
+	d.Set("specify_ip_ranges", networkOffering.Specifyipranges)
+	d.Set("specify_as_number", networkOffering.Specifyasnumber)
+	d.Set("internet_protocol", networkOffering.Internetprotocol)
+	d.Set("routing_mode", networkOffering.Routingmode)
+	d.Set("max_connections", networkOffering.Maxconnections)
+
+	// Set supported services
+	if len(networkOffering.Service) > 0 {
+		services := make([]string, len(networkOffering.Service))
+		for i, service := range networkOffering.Service {
+			services[i] = service.Name
+		}
+		d.Set("supported_services", services)
+	}
+
+	// Set service provider list
+	if len(networkOffering.Service) > 0 {
+		serviceProviders := make(map[string]string)
+		for _, service := range networkOffering.Service {
+			if len(service.Provider) > 0 {
+				serviceProviders[service.Name] = service.Provider[0].Name
+			}
+		}
+		d.Set("service_provider_list", serviceProviders)
+	}
 
 	return nil
 }

cloudstack/data_source_cloudstack_network_offering_test.go

@@ -65,7 +65,6 @@ func TestAccNetworkOfferingDataSource_withAdditionalParams(t *testing.T) {
 					resource.TestCheckResourceAttrPair(datasourceName, "conserve_mode", resourceName, "conserve_mode"),
 					resource.TestCheckResourceAttrPair(datasourceName, "for_vpc", resourceName, "for_vpc"),
 					resource.TestCheckResourceAttrPair(datasourceName, "specify_vlan", resourceName, "specify_vlan"),
-					resource.TestCheckResourceAttrPair(datasourceName, "specify_ip_ranges", resourceName, "specify_ip_ranges"),
 					resource.TestCheckResourceAttrPair(datasourceName, "network_mode", resourceName, "network_mode"),
 					resource.TestCheckResourceAttrPair(datasourceName, "enable", resourceName, "enable"),
 				),
@@ -178,7 +177,6 @@ resource "cloudstack_network_offering" "net-off-resource"{
   enable            = true
   for_vpc           = false
   specify_vlan      = true
-  specify_ip_ranges = true
   supported_services = ["Dhcp", "Dns", "Firewall", "Lb", "SourceNat"]
   service_provider_list = {
     Dhcp      = "VirtualRouter"
@@ -275,7 +273,6 @@ resource "cloudstack_network_offering" "net-off-resource"{
   for_vpc           = false
   for_nsx           = false
   specify_vlan      = true
-  specify_ip_ranges = true
   specify_as_number = false
   internet_protocol = "IPv4"
   routing_mode      = "Static"