Skip to content

Add cloudstack_limits data source and resource #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add cloudstack_limits data source and resource #197

wants to merge 5 commits into from

Conversation

ianc769
Copy link

@ianc769 ianc769 commented Jul 15, 2025

Adding limits as a terraform managed resource option -> https://cloudstack.apache.org/api/apidocs-4.20/apis/updateResourceLimit.html

Contributes to #82

Using this code for example:

resource "random_uuid" "example" {
}

resource "cloudstack_domain" "example" {
  name             = "example-domain"
  network_domain   = "example.local"
  domain_id        = random_uuid.example.result
  parent_domain_id = "65c9befb-1a1c-11f0-85c0-460f7764ea25"
}

# Set limit in a domain
resource "cloudstack_limits" "cpu_limit" {
  type       = "cpu"
  max        = 42
  domainid   = random_uuid.example.result
  depends_on = [cloudstack_domain.example]

}

# Set volume limit for a specific account in a domain
resource "cloudstack_limits" "volume_limit" {
  type     = "volume"
  max      = 22
  account  = "limits.test"
  domainid = "861bf423-e531-48dc-9bdc-a3183ae0fb0f"
}

# Set primary storage limit for a project
resource "cloudstack_limits" "storage_limit" {
  type      = "primarystorage"
  max       = 1423                                   # GB
  projectid = "c3638a06-9598-4c34-8f89-891beda43eca" // Example project ID
}
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # cloudstack_domain.example will be created
  + resource "cloudstack_domain" "example" {
      + domain_id        = (known after apply)
      + id               = (known after apply)
      + name             = "example-domain"
      + network_domain   = "example.local"
      + parent_domain_id = "65c9befb-1a1c-11f0-85c0-460f7764ea25"
    }

  # cloudstack_limits.cpu_limit will be created
  + resource "cloudstack_limits" "cpu_limit" {
      + domainid = (known after apply)
      + id       = (known after apply)
      + max      = 42
      + type     = "cpu"
    }

  # cloudstack_limits.storage_limit will be created
  + resource "cloudstack_limits" "storage_limit" {
      + id        = (known after apply)
      + max       = 1423
      + projectid = "c3638a06-9598-4c34-8f89-891beda43eca"
      + type      = "primarystorage"
    }

  # cloudstack_limits.volume_limit will be created
  + resource "cloudstack_limits" "volume_limit" {
      + account  = "limits.test"
      + domainid = "861bf423-e531-48dc-9bdc-a3183ae0fb0f"
      + id       = (known after apply)
      + max      = 22
      + type     = "volume"
    }

  # random_uuid.example will be created
  + resource "random_uuid" "example" {
      + id     = (known after apply)
      + result = (known after apply)
    }

Plan: 5 to add, 0 to change, 0 to destroy.

random_uuid.example: Creating...
random_uuid.example: Creation complete after 0s [id=3e435b24-880a-6bae-50a6-fbd5c9be402b]
cloudstack_limits.volume_limit: Creating...
cloudstack_limits.storage_limit: Creating...
cloudstack_domain.example: Creating...
cloudstack_domain.example: Creation complete after 0s [id=3e435b24-880a-6bae-50a6-fbd5c9be402b]
cloudstack_limits.volume_limit: Creation complete after 0s [id=2-account-limits.test-861bf423-e531-48dc-9bdc-a3183ae0fb0f]
cloudstack_limits.cpu_limit: Creating...
cloudstack_limits.storage_limit: Creation complete after 0s [id=10-project-c3638a06-9598-4c34-8f89-891beda43eca]
cloudstack_limits.cpu_limit: Creation complete after 0s [id=8-domain-3e435b24-880a-6bae-50a6-fbd5c9be402b]

Apply complete! Resources: 5 added, 0 changed, 0 destroyed.

@ianc769
feat: add cloudstack_limits data source and resource management
3494af6 
- Implemented data source for retrieving CloudStack resource limits.
- Added resource management for setting and updating resource limits for accounts, domains, and projects.
- Updated documentation for cloudstack_limits with usage examples and argument references.
@ianc769 ianc769 mentioned this pull request Jul 17, 2025
Open
@DaanHoogland DaanHoogland requested a review from Copilot August 6, 2025 08:04
Copilot

This comment was marked as outdated.

Sign in to view

@ianc769
feat: update CloudStack limits handling for zero resources and unlimi…
0b9d7fc 
…ted resources

Implimenting copilot suggestions for d.GetOk
@ianc769 ianc769 requested a review from Copilot August 7, 2025 18:17
Copilot

This comment was marked as outdated.

Sign in to view

@ianc769 @Copilot
tabs to spaces
9be4bba 
Co-authored-by: Copilot <[email protected]>
@ianc769 ianc769 requested a review from Copilot August 7, 2025 18:27
Copilot
Copilot AI reviewed Aug 7, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CloudStack limits as both a Terraform data source and resource, enabling management of resource limits for accounts, domains, and projects within CloudStack through the updateResourceLimit API.

  • Adds cloudstack_limits resource for managing resource limits with support for various resource types (instance, ip, volume, snapshot, template, project, network, vpc, cpu, memory, primarystorage, secondarystorage)
  • Adds cloudstack_limits data source for retrieving existing resource limit information
  • Provides comprehensive test coverage for different resource types and scenarios including unlimited and zero limits

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cloudstack/provider.go Registers the new data source and resource in the provider
cloudstack/resource_cloudstack_limits.go Core resource implementation with CRUD operations for managing CloudStack limits
cloudstack/data_source_cloudstack_limits.go Data source implementation for reading CloudStack resource limits
cloudstack/resource_cloudstack_limits_test.go Comprehensive test suite covering various limit scenarios and resource types
website/docs/r/limits.html.markdown Resource documentation with usage examples and parameter descriptions
website/docs/d/limits.html.markdown Data source documentation with usage examples and attribute descriptions

@kiranchavala kiranchavala added this to the v0.6.0 milestone Aug 8, 2025
@ianc769
- Comment project related limit testing
0a72f69 
- update resourceCloudStackLimitsRead to handle different ID formats
- rewrite resourceCloudStackLimitsImport to handle different ID formats
- Support -1 (Unlimited) and 0 (zero) limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ianc769 @kiranchavala