fix typo

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java

@@ -425,8 +425,8 @@ private ConsoleEndpoint generateAccessEndpoint(Long vmId, String sessionUuid, St
         return consoleEndpoint;
     }
 
-    protected ConsoleConnectionDetails getConsoleConnectionDetailsFoxExternalVm(ConsoleConnectionDetails details,
-                                VirtualMachine vm, HostVO host) {
+    protected ConsoleConnectionDetails getConsoleConnectionDetailsForExternalVm(ConsoleConnectionDetails details,
+                            VirtualMachine vm, HostVO host) {
         Answer answer = managementServer.getExternalVmConsole(vm, host);
         if (answer == null) {
             logger.error("Unable to get console access details for external {} on {}: answer is null.", vm, host);
@@ -481,7 +481,7 @@ protected ConsoleConnectionDetails getConsoleConnectionDetails(VirtualMachine vm
         }
         ConsoleConnectionDetails details = new ConsoleConnectionDetails(vm.getVncPassword(), locale, tag, displayName);
         if (Hypervisor.HypervisorType.External.equals(host.getHypervisorType())) {
-            return getConsoleConnectionDetailsFoxExternalVm(details, vm, host);
+            return getConsoleConnectionDetailsForExternalVm(details, vm, host);
         }
         Pair<String, Integer> hostPortInfo = getHostAndPortForKVMMaintenanceHostIfNeeded(host, vmDetails);
         if (hostPortInfo == null) {

server/src/test/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImplTest.java

@@ -339,7 +339,7 @@ public void returnsNullWhenAnswerIsNull() {
 
         Mockito.when(managementServer.getExternalVmConsole(vm, host)).thenReturn(null);
 
-        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsFoxExternalVm(details, vm, host);
+        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsForExternalVm(details, vm, host);
 
         Assert.assertNull(result);
     }
@@ -355,7 +355,7 @@ public void returnsNullWhenAnswerResultIsFalse() {
         Mockito.when(answer.getDetails()).thenReturn("Error details");
         Mockito.when(managementServer.getExternalVmConsole(vm, host)).thenReturn(answer);
 
-        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsFoxExternalVm(details, vm, host);
+        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsForExternalVm(details, vm, host);
 
         Assert.assertNull(result);
     }
@@ -370,7 +370,7 @@ public void returnsNullWhenAnswerIsNotOfTypeGetExternalConsoleAnswer() {
         Mockito.when(answer.getResult()).thenReturn(true);
         Mockito.when(managementServer.getExternalVmConsole(vm, host)).thenReturn(answer);
 
-        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsFoxExternalVm(details, vm, host);
+        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsForExternalVm(details, vm, host);
 
         Assert.assertNull(result);
     }
@@ -392,7 +392,7 @@ public void setsDetailsWhenAnswerIsValid() {
         Mockito.when(answer.getPassword()).thenReturn(expectedPassword);
         Mockito.when(managementServer.getExternalVmConsole(vm, host)).thenReturn(answer);
 
-        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsFoxExternalVm(details, vm, host);
+        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsForExternalVm(details, vm, host);
 
         Assert.assertNotNull(result);
         Assert.assertEquals(expectedHost, result.getHost());
@@ -413,7 +413,7 @@ public void doesNotSetSidWhenPasswordIsBlank() {
         Mockito.when(answer.getPassword()).thenReturn("");
         Mockito.when(managementServer.getExternalVmConsole(vm, host)).thenReturn(answer);
 
-        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsFoxExternalVm(details, vm, host);
+        ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetailsForExternalVm(details, vm, host);
 
         Assert.assertNotNull(result);
         Assert.assertEquals("10.0.0.1", result.getHost());
@@ -487,12 +487,12 @@ public void returnsDetailsForExternalHypervisor() {
         Mockito.when(host.getHypervisorType()).thenReturn(Hypervisor.HypervisorType.External);
         Mockito.when(vmInstanceDetailsDao.listDetailsKeyPairs(Mockito.anyLong(), Mockito.anyList())).thenReturn(Map.of());
 
-        Mockito.doReturn(details).when(consoleAccessManager).getConsoleConnectionDetailsFoxExternalVm(Mockito.any(), Mockito.eq(vm), Mockito.eq(host));
+        Mockito.doReturn(details).when(consoleAccessManager).getConsoleConnectionDetailsForExternalVm(Mockito.any(), Mockito.eq(vm), Mockito.eq(host));
 
         ConsoleConnectionDetails result = consoleAccessManager.getConsoleConnectionDetails(vm, host);
 
         Assert.assertNotNull(result);
-        Mockito.verify(consoleAccessManager).getConsoleConnectionDetailsFoxExternalVm(Mockito.any(), Mockito.eq(vm), Mockito.eq(host));
+        Mockito.verify(consoleAccessManager).getConsoleConnectionDetailsForExternalVm(Mockito.any(), Mockito.eq(vm), Mockito.eq(host));
     }
 
     @Test