allow actual execution, fix script

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

plugins/hypervisors/external/src/main/java/org/apache/cloudstack/hypervisor/external/provisioner/simpleprovisioner/SimpleExternalProvisioner.java

@@ -544,12 +544,12 @@ public Pair<Boolean, String> executeExternalCommand(String file, String action,
             builder.redirectErrorStream(true);
 
             if (IS_DEBUG) {
-                logger.info("Executable: {}",executablePath);
-                logger.info("Action: {} with wait: {}", action, wait);
-                logger.info("Data file: {}", dataFile);
-                return new Pair<>(true, "Operation successful!");
+                logger.debug("Executable: {}",executablePath);
+                logger.debug("Action: {} with wait: {}", action, wait);
+                logger.debug("Data file: {}", dataFile);
+//                return new Pair<>(true, "Operation successful!");
             }
-            logger.debug("Executing command: {}", command);
+            logger.debug("Executing command: {}", action);
             Process process = builder.start();
             boolean finished = process.waitFor(wait, TimeUnit.SECONDS);
             if (!finished) {

scripts/vm/hypervisor/external/simpleExternalProvisioner/provisioner.sh

@@ -80,14 +80,22 @@ status() {
 }
 
 action=$1
-parameters=$2
-wait_time=$3
+parameters_file="$2"
+wait_time="$3"
 
-if [[ -z $action || -z $parameters ]]; then
+if [[ -z "$action" || -z "$parameters_file" ]]; then
     echo '{"error":"Missing required arguments"}'
     exit 1
 fi
 
+if [[ ! -r "$parameters_file" ]]; then
+    echo '{"error":"File not found or unreadable"}'
+    exit 1
+fi
+
+# Read file content as parameters (assumes space-separated arguments)
+parameters=$(<"$parameters_file")
+
 case $action in
     prepare)
         prepare "$parameters"