Skip to content

Commit 0b1950b

Browse files
committed
fixme
1 parent dc4a41e commit 0b1950b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

server/src/main/java/com/cloud/network/NetworkServiceImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5148,6 +5148,7 @@ public PhysicalNetworkTrafficType addTrafficTypeToPhysicalNetwork(Long physicalN
51485148
if (TrafficType.Public.equals(trafficType)) {
51495149
List<String> isolationMethods = network.getIsolationMethods();
51505150
if ((isolationMethods.size() == 1 && isolationMethods.get(0).toLowerCase().equals("vxlan"))
5151+
// TODO: what happens if there are multiple isolation methods, why are multiple isolation methods allowed per pnet? They seem to be filterable by provider/preifx (PhysicalNetwork.java). Documentation says only two are allowed but code and tests contradict this.
51515152
|| (isolationMethod != null && isolationMethods.contains(isolationMethod) && isolationMethod.toLowerCase().equals("vxlan"))) {
51525153
// find row in networks table that is defined as 'Public', created when zone was deployed
51535154
NetworkVO publicNetwork = _networksDao.listByZoneAndTrafficType(network.getDataCenterId(), TrafficType.Public).get(0);

0 commit comments

Comments
 (0)