prevent addition of counters with same name, provider and source as a non-deleted counter

Author: Pearl1594

engine/schema/src/main/java/com/cloud/network/as/dao/CounterDao.java

@@ -24,6 +24,7 @@
 import com.cloud.utils.db.GenericDao;
 
 public interface CounterDao extends GenericDao<CounterVO, Long> {
+    CounterVO findByNameProviderSource(String name, String source, String provider);
     public List<CounterVO> listCounters(Long id, String name, String source, String provider, String keyword, Filter filter);
 
 }

engine/schema/src/main/java/com/cloud/network/as/dao/CounterDaoImpl.java

@@ -32,6 +32,7 @@
 @Component
 public class CounterDaoImpl extends GenericDaoBase<CounterVO, Long> implements CounterDao {
     final SearchBuilder<CounterVO> AllFieldsSearch;
+    final SearchBuilder<CounterVO> CounterNameSearch;
 
     protected CounterDaoImpl() {
         AllFieldsSearch = createSearchBuilder();
@@ -40,6 +41,21 @@ protected CounterDaoImpl() {
         AllFieldsSearch.and("source", AllFieldsSearch.entity().getSource(), Op.EQ);
         AllFieldsSearch.and("provider", AllFieldsSearch.entity().getProvider(), Op.EQ);
         AllFieldsSearch.done();
+
+        CounterNameSearch = createSearchBuilder();
+        CounterNameSearch.and("name", CounterNameSearch.entity().getName(), Op.EQ);
+        CounterNameSearch.and("source", CounterNameSearch.entity().getSource(), Op.EQ);
+        CounterNameSearch.and("provider", CounterNameSearch.entity().getProvider(), Op.EQ);
+        CounterNameSearch.done();
+    }
+
+    @Override
+    public CounterVO findByNameProviderSource(String name, String source, String provider) {
+        SearchCriteria<CounterVO> sc = CounterNameSearch.create();
+        sc.setParameters("name", name);
+        sc.setParameters("source", source);
+        sc.setParameters("provider", provider);
+        return findOneBy(sc);
     }
 
     @Override

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

@@ -1452,7 +1452,7 @@ public AutoScaleVmGroup disableAutoScaleVmGroup(Long id) {
     @DB
     public Counter createCounter(CreateCounterCmd cmd) {
         String source = cmd.getSource().toUpperCase();
-        String name = cmd.getName();
+    String name = cmd.getName();
         Counter.Source src;
         // Validate Source
         try {
@@ -1469,6 +1469,10 @@ public Counter createCounter(CreateCounterCmd cmd) {
 
         CounterVO counter = null;
 
+        CounterVO existingCounter = counterDao.findByNameProviderSource(name, source, provider.getName());
+        if (existingCounter != null) {
+            throw new InvalidParameterValueException("Counter with name " + name + " already exists");
+        }
         logger.debug("Adding Counter " + name);
         counter = counterDao.persist(new CounterVO(src, name, cmd.getValue(), provider));