Skip to content

Commit 1cb1962

Browse files
committed
monir fixups
1 parent b47db16 commit 1cb1962

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

server/src/main/java/com/cloud/storage/OCFS2ManagerImpl.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,12 @@ public boolean stop() {
8888
private List<Ternary<Integer, String, String>> marshalNodes(List<HostVO> hosts) {
8989
Integer i = 0;
9090
List<Ternary<Integer, String, String>> lst = new ArrayList<Ternary<Integer, String, String>>();
91-
for (HostVO h : hosts) {
91+
for (HostVO host : hosts) {
9292
/**
9393
* Don't show "node" in node name otherwise OVM's utils/config_o2cb.sh will be going crazy
9494
*/
95-
String nodeName = "ovm_" + h.getPrivateIpAddress().replace(".", "_");
96-
Ternary<Integer, String, String> node = new Ternary<Integer, String, String>(i, h.getPrivateIpAddress(), nodeName);
95+
String nodeName = "ovm_" + host.getPrivateIpAddress().replace(".", "_");
96+
Ternary<Integer, String, String> node = new Ternary<Integer, String, String>(i, host.getPrivateIpAddress(), nodeName);
9797
lst.add(node);
9898
i++;
9999
}
@@ -102,14 +102,14 @@ private List<Ternary<Integer, String, String>> marshalNodes(List<HostVO> hosts)
102102

103103
private boolean prepareNodes(String clusterName, List<HostVO> hosts) {
104104
PrepareOCFS2NodesCommand cmd = new PrepareOCFS2NodesCommand(clusterName, marshalNodes(hosts));
105-
for (HostVO h : hosts) {
106-
Answer ans = _agentMgr.easySend(h.getId(), cmd);
105+
for (HostVO host : hosts) {
106+
Answer ans = _agentMgr.easySend(host.getId(), cmd);
107107
if (ans == null) {
108-
logger.debug("Host {} is not in UP state, skip preparing OCFS2 node on it", h);
108+
logger.debug("Host {} is not in UP state, skip preparing OCFS2 node on it", host);
109109
continue;
110110
}
111111
if (!ans.getResult()) {
112-
logger.warn("PrepareOCFS2NodesCommand failed on host {} {}", h, ans.getDetails());
112+
logger.warn("PrepareOCFS2NodesCommand failed on host {} {}", host, ans.getDetails());
113113
return false;
114114
}
115115
}

server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,9 @@ protected void checkTagsDeletePermission(List<ResourceTag> tagsToDelete, Account
167167
for (ResourceTag resourceTag : tagsToDelete) {
168168
Account owner = _accountMgr.getAccount(resourceTag.getAccountId());
169169
if(logger.isDebugEnabled()) {
170-
logger.debug("Resource Tag Id: {}, Resource Tag Uuid: {}, Resource Tag Type: {}, " +
171-
"Resource Tag Account: {}", resourceTag.getResourceId(),
172-
resourceTag.getResourceUuid(), resourceTag.getResourceType(), owner);
170+
logger.debug("Resource Tag Id: {}, Uuid: {}, Type: {}, Account: {}",
171+
resourceTag.getResourceId(), resourceTag.getResourceUuid(),
172+
resourceTag.getResourceType(), owner);
173173
}
174174
if (caller.getAccountId() != resourceTag.getAccountId()) {
175175
if(logger.isDebugEnabled()) {

0 commit comments

Comments
 (0)