Remove conditional as it was never actually reached in the original flow

BryanMLima · BryanMLima · commit 1e9127667933 · 2024-11-28T17:22:02.000-03:00
diff --git a/server/src/main/java/com/cloud/agent/manager/allocator/impl/RandomAllocator.java b/server/src/main/java/com/cloud/agent/manager/allocator/impl/RandomAllocator.java
@@ -127,10 +127,6 @@ public List<Host> allocateTo(VirtualMachineProfile vmProfile, DeploymentPlan pla
     @Override
     public List<Host> allocateTo(VirtualMachineProfile vmProfile, DeploymentPlan plan, Type type, ExcludeList avoid, List<? extends Host> hosts, int returnUpTo,
                                  boolean considerReservedCapacity) {
-        if (CollectionUtils.isEmpty(hosts)) {
-            logger.debug("Random Allocator found 0 hosts as given host list is empty");
-            return new ArrayList<>();
-        }
         return findSuitableHosts(vmProfile, plan, type, avoid, hosts, returnUpTo, considerReservedCapacity);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -127,10 +127,6 @@ public List<Host> allocateTo(VirtualMachineProfile vmProfile, DeploymentPlan pla`
`127`	`127`	`@Override`
`128`	`128`	`public List<Host> allocateTo(VirtualMachineProfile vmProfile, DeploymentPlan plan, Type type, ExcludeList avoid, List<? extends Host> hosts, int returnUpTo,`
`129`	`129`	`boolean considerReservedCapacity) {`
`130`		`- if (CollectionUtils.isEmpty(hosts)) {`
`131`		`- logger.debug("Random Allocator found 0 hosts as given host list is empty");`
`132`		`- return new ArrayList<>();`
`133`		`- }`
`134`	`130`	`return findSuitableHosts(vmProfile, plan, type, avoid, hosts, returnUpTo, considerReservedCapacity);`
`135`	`131`	`}`
`136`	`132`	`}`